Fix thumbnail not loading for newly created sites - #2484
Merged
Conversation
4 tasks
ivan-ottinger
force-pushed
the
fix/thumbnail-load-on-site-creation
branch
from
January 27, 2026 14:30
320a79c to
2b80f35
Compare
ivan-ottinger
force-pushed
the
fix/thumbnail-load-on-site-creation
branch
from
January 27, 2026 14:43
2b80f35 to
952de6a
Compare
gcsecsey
approved these changes
Jan 27, 2026
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Thanks @ivan-ottinger for tackling this, changes LGTM and work well!
Starting a new site:
CleanShot.2026-01-27.at.14.57.25.mp4
Updating theme:
CleanShot.2026-01-27.at.14.57.52.mp4
Simulating an error:
CleanShot.2026-01-27.at.14.59.11.mp4
epeicher
approved these changes
Jan 27, 2026
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ivan-ottinger! I have tested it, and I can consistently see the preview generated successfully, I can also see the error as expected. LGTM!
CleanShot.2026-01-27.at.15.56.25.mp4
Error:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
When a new site is created, there was a race condition in the IPC event sequencing:
theme-details-loadedarrives and setsloadingThemeDetails = falsethumbnail-loadinghasn't arrived yet, soloadingThumbnailsis stillundefinedsrconError, setting the error state permanentlythumbnail-loadedfinally arrives, the error state is already set and "Preview unavailable" is shownThe fix ensures proper sequencing by:
thumbnail-loadingearly (at the same time astheme-details-loading) when creating a new sitethumbnail-loadedorthumbnail-load-errorto complete the loading statethumbnail-loadingbefore updating the thumbnail so the skeleton showsTesting Instructions
New site creation
Theme changes
Error handling
Pre-merge Checklist