Migrate HTTPS certificates to `~/.studio/certificates` by fredrikekelund · Pull Request #2871 · Automattic/studio

fredrikekelund · 2026-03-23T10:19:42Z

Related issues

Related to STU-1350
Fixes STU-1416

How AI was used in this PR

Not at all.

Proposed Changes

Add a copyHttpsCertsToWellKnown migration (conforming to the Migration interface from Migrate appdata to ~/.studio/appdata.json with versioned migrations #2836) that copies the certificates directory from the old path (relative to the Electron installation config files) to the new path (a well-known location: ~/.studio/certificates).

Testing Instructions

Have at least one site with HTTPS configured (do this before checking out this branch)
Check out this branch
npm start
ls ~/.studio/certificates
Ensure that the new certificates directory exists
Ensure that the HTTPS site you had since before still works

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

* STU-1350: Read site data from CLI instead of appdata Studio now reads site data via `site list --format json` at startup and maintains state through CLI events subscriber. Removes direct appdata reads for site details, simplifies SiteServer create/start flows, and removes waitForSiteEvent synchronization. * Fix lint: indentation in index.test.ts * Fix typecheck: narrow SiteDetails union before accessing url * Remove dead url branch in SiteServer.create — events subscriber handles it * Address PR review feedback: shared schemas, keyValuePair output, simplify start/delete

…onfig-dev

* STU-1350: Read site data from CLI instead of appdata Studio now reads site data via `site list --format json` at startup and maintains state through CLI events subscriber. Removes direct appdata reads for site details, simplifies SiteServer create/start flows, and removes waitForSiteEvent synchronization. * Fix lint: indentation in index.test.ts * STU-1350: Move CLI site data to dedicated cli.json config file Split site data from appdata-v1.json into a new CLI-owned config at ~/.studio/cli.json. Studio now reads sites exclusively via `studio site list` and _events. The CLI is the source of truth for site configuration. Auth tokens, snapshots, locale remain in appdata. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * Fix delete test after trunk merge: use saveCliConfig instead of saveAppdata * Extend require-lock-before-save eslint rule to support cli-config lock/save pairs * Use shared lockfile constants and extract DEFAULT_CLI_CONFIG * Fix typecheck: narrow SiteDetails union before accessing url * Remove dead url branch in SiteServer.create — events subscriber handles it * Fix lint: remove extra blank line in cli-config.ts * triggert ci * Update e2e tests to read site data from cli.json * Address PR review feedback for cli-config - Use structuredClone for DEFAULT_CLI_CONFIG deep copy - Rename daemon-paths.ts to paths.ts, extract STUDIO_CLI_HOME - Split config schema for version mismatch detection - Improve readCliConfig error handling with version check - Rename removeSite to removeSiteFromConfig - Revert UPDATED event handler to warn for unknown sites * Fix AI files to import site functions from cli-config instead of appdata --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

…onfig-dev

* Apply decoupled config strategy to preview sites (STU-1350) - CLI stores/reads preview site data from cli.json instead of appdata - Studio reads preview sites via CLI commands (preview list --format json) - Added preview set command for updating snapshot settings (--name) - Added --name option to preview create command - Moved refreshSnapshots to store initialization with test guard - Fixed snapshot-slice test mock setup to avoid module-load timing issues * Emit snapshot events to Studio via _events for realtime updates * Move snapshot name generation from cli-config to preview create command * Split cli-config.ts into folder structure (core, sites, snapshots) * Rename site-events to cli-events and enrich snapshot events with inline data (STU-1350) * Fix snapshot update infinite loop and preview set error handling * Unify CLI event emitter, share event schemas in cli-events, and clean up daemon-client (STU-1350) * trigger ci * Fix import order lint errors in core.ts and site-server.ts * Address PR review: add stdout json output, addSnapshot action, reusable usage count helper, fix listener state bug * Remove barrel file, replace z.nativeEnum with z.enum, update imports to direct paths * Fix import order in cli-events.ts and remove unused test imports

…ramework

* Wire auth and locale to shared.json, AI settings to cli.json Move auth token reads/writes from appdata to shared-config for Desktop+CLI. Move locale reads/writes to shared-config (Desktop saves, CLI reads). Move aiProvider and anthropicApiKey from shared-config to cli-config (CLI-only). Remove auth and locale fields from appdata schema and types since they're now in separate files. Update all imports and tests accordingly. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * Move CLI telemetry stats from appdata to cli-config * Fix import order lint errors * Remove CLI appdata dependency and move infrastructure paths to ~/.studio * Revert server-files and certificate paths to appdata directory * Watch shared config for auth changes from CLI * Align shared config watcher with user-data watcher pattern * trigger ci * Address PR review feedback: events-based auth, rename types, deduplicate schemas * Fix prettier formatting in auth test * Fix shared-config mock in tests to export authTokenSchema * Use z.literal for config version validation, remove unused re-export, update test mocks * Extract authTokenSchema to avoid Node.js imports in renderer bundle * trigger ci * Fix daemon test to use os.tmpdir() for Windows compatibility * Make CLI event emission best-effort in auth commands * Throw on shared config version mismatch instead of silently returning defaults * Add line break before version mismatch error message * Handle version mismatch errors through standard Logger flow in auth commands * Show only display name in AI chat status bar --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

…nto stu-1350-decoupled-config-dev-v3 # Conflicts: # apps/cli/lib/appdata.ts # apps/cli/lib/tests/appdata.test.ts

…pdata.json

…ecord<id, AppdataSiteData>

…sing in migration

…-handlers

…nto stu-1350-decoupled-config-dev-v3

…ants

…config-dev-v3

…ures

fredrikekelund · 2026-03-23T10:21:52Z

src/storage/paths is already mocked globally in apps/studio/vitest.setup.ts

bcotrim

Code LGTM and nice cleanup on tests!

Something I would like to discuss before we land, would it make sense to run this from the CLI migrations instead?
Since it migration copies the cert from the Studio folder to the CLI folder, it seems to make sense to have it run from the CLI. What do you think?

fredrikekelund · 2026-03-23T12:42:00Z

would it make sense to run this from the CLI migrations instead

Same as with the config file migration, the place where we need a guarantee that the code works with the current file structure is primarily the app, not the CLI.

I also think it's sensible for the old owner (the Studio app) to execute the move to the new owner (the CLI).

migration copies the cert from the Studio folder to the CLI folder

~/.studio/certificates is not 100% under CLI management, as I see it. Yes, we're moving towards an architecture where the CLI acts as a back-end API, and it will probably be the only component that touches that directory. Still, the first difference between the old location and this one is that it's "well-known" (fully deterministic).

bcotrim

Let's keep it in Studio then.
LGTM 👍

…ed-config-dev-v4

wpmobilebot · 2026-03-23T19:52:23Z

📊 Performance Test Results

Comparing 462a336 vs trunk

app-size

Metric	trunk	`462a336`	Diff	Change
App Size (Mac)	1237.57 MB	1237.57 MB	0.00 MB	⚪ 0.0%

site-editor

Metric	trunk	`462a336`	Diff	Change
load	2032 ms	1874 ms	158 ms	🟢 -7.8%

site-startup

Metric	trunk	`462a336`	Diff	Change
siteCreation	7079 ms	7076 ms	3 ms	⚪ 0.0%
siteStartup	3935 ms	3937 ms	+2 ms	⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

bcotrim and others added 30 commits March 11, 2026 16:29

Merge remote-tracking branch 'origin/trunk' into stu-1350-decoupled-c…

9e72f3f

…onfig-dev

Merge branch 'trunk' into stu-1350-decoupled-config-dev

8daf4a9

Merge remote-tracking branch 'origin/trunk' into stu-1350-decoupled-c…

7748599

…onfig-dev

Merge trunk into stu-1350-decoupled-config-dev

a87533b

Merge branch 'trunk' into stu-1350-decoupled-config-dev

b4b6e42

Merge branch 'trunk' into stu-1350-decoupled-config-dev

304a3da

Fix AI tools test mocks to use cli-config instead of appdata

163b971

Merge trunk and resolve conflicts for cli-config decoupling

147bd6d

Migrate appdata to ~/.studio/appdata.json with extensible migration f…

cfa000f

…ramework

Merge stu-1350-decoupled-config-dev and resolve conflicts

9d5ead9

Merge branch 'trunk' into stu-1350-decoupled-config-dev

12b98f1

Move appdata migration from CLI to Studio Desktop

aeb2e3a

Merge remote-tracking branch 'origin/stu-1350-decoupled-config-dev' i…

7a34728

…nto stu-1350-decoupled-config-dev-v3 # Conflicts: # apps/cli/lib/appdata.ts # apps/cli/lib/tests/appdata.test.ts

Rewrite appdata migration to split into shared.json, cli.json, and ap…

a6a3838

…pdata.json

trigger ci

63b8b8e

Ensure .studio directory exists before lockfile and fix import order

46b0358

Fix readFile mock type to return Buffer instead of string

4dd6080

Refactor appdata to store only Desktop-specific state with sites as R…

852cdc9

…ecord<id, AppdataSiteData>

Address PR feedback: rename to app.json and siteMetadata, use zod par…

92d5be2

…sing in migration

Fix prettier formatting in user-data test

29fa739

Fix e2e migration by respecting E2E_APP_DATA_PATH in getOldAppdataPath

a317a82

Merge trunk and resolve conflicts in _events.ts and user-settings ipc…

a1b7c38

…-handlers

Merge remote-tracking branch 'origin/stu-1350-decoupled-config-dev' i…

6db60dd

…nto stu-1350-decoupled-config-dev-v3

new migration interface

0bd4c58

studio migrations

f8e9258

studio migrations

aca873d

bcotrim and others added 8 commits March 20, 2026 14:16

cli migrations

ef52842

Merge branch 'trunk' into stu-1350-decoupled-config-dev

23d18ed

Rename appdata references, centralize config paths and lockfile const…

cea5b56

…ants

Isolate e2e config directory to fix test failures

f211f3a

Merge branch 'trunk' into stu-1350-decoupled-config-dev

6e95cb5

Merge branch 'stu-1350-decoupled-config-dev' into stu-1350-decoupled-…

e58b6d4

…config-dev-v3

Move site metadata cleanup to SiteServer, fix typecheck and test fail…

ec6f7e1

…ures

HTTPS certificate migration

8c18041

fredrikekelund requested review from a team and bcotrim March 23, 2026 10:19

fredrikekelund self-assigned this Mar 23, 2026

fredrikekelund commented Mar 23, 2026

View reviewed changes

Rename file

205f8e6

bcotrim reviewed Mar 23, 2026

View reviewed changes

Add APP_CONFIG_LOCKFILE_NAME constant and fix test failures

9cd3740

bcotrim approved these changes Mar 23, 2026

View reviewed changes

Merge branch 'stu-1350-decoupled-config-dev-v3' into stu-1350-decoupl…

c19fc13

…ed-config-dev-v4

Base automatically changed from stu-1350-decoupled-config-dev-v3 to stu-1350-decoupled-config-dev March 23, 2026 15:14

Base automatically changed from stu-1350-decoupled-config-dev to trunk March 23, 2026 17:52

fredrikekelund added 2 commits March 23, 2026 20:26

Merge branch 'trunk' into stu-1350-decoupled-config-dev-v4

9789cb4

Fix merge conflict

94946a0

fredrikekelund enabled auto-merge (squash) March 23, 2026 19:36

Load sites from SiteServer.getAll()

462a336

fredrikekelund merged commit 9290f01 into trunk Mar 23, 2026
8 of 10 checks passed

fredrikekelund deleted the stu-1350-decoupled-config-dev-v4 branch March 23, 2026 20:03

bcotrim mentioned this pull request Mar 23, 2026

Fix typecheck errors in AI skills handlers after config split #2877

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate HTTPS certificates to `~/.studio/certificates` - #2871

Migrate HTTPS certificates to `~/.studio/certificates`#2871
fredrikekelund merged 44 commits into
trunkfrom
stu-1350-decoupled-config-dev-v4

fredrikekelund commented Mar 23, 2026

fredrikekelund Mar 23, 2026

bcotrim left a comment

fredrikekelund commented Mar 23, 2026

bcotrim left a comment

wpmobilebot commented Mar 23, 2026 •

edited

Loading

Uh oh!

Labels

3 participants

Uh oh!

Conversation

fredrikekelund commented Mar 23, 2026

Related issues

How AI was used in this PR

Proposed Changes

Testing Instructions

Pre-merge Checklist

fredrikekelund Mar 23, 2026

Choose a reason for hiding this comment

bcotrim left a comment

Choose a reason for hiding this comment

fredrikekelund commented Mar 23, 2026

bcotrim left a comment

Choose a reason for hiding this comment

wpmobilebot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Test Results

app-size

site-editor

site-startup

Uh oh!

Labels

3 participants

wpmobilebot commented Mar 23, 2026 •

edited

Loading