Skip to content

Fix typecheck errors in AI skills handlers after config split - #2877

Closed
bcotrim wants to merge 2 commits into
trunkfrom
fix-trunk-lint
Closed

Fix typecheck errors in AI skills handlers after config split#2877
bcotrim wants to merge 2 commits into
trunkfrom
fix-trunk-lint

Conversation

@bcotrim

@bcotrim bcotrim commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Related issues

  • N/A

How AI was used in this PR

AI identified the root cause (config split removed sites from UserData) and applied the fix using SiteServer.getAllDetails().

Proposed Changes

  • Replace loadUserData().sites with SiteServer.getAllDetails() in three AI skills IPC handlers (getWordPressSkillsStatusAllSites, installWordPressSkillsToAllSites, removeWordPressSkillFromAllSites) that broke after the decoupled config file strategy was merged.

Testing Instructions

  • Run npm run typecheck — should pass with no errors
  • Run npm test -- apps/studio/src/tests/ipc-handlers.test.ts — all tests should pass

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim bcotrim self-assigned this Mar 23, 2026
@bcotrim
bcotrim requested review from a team and fredrikekelund March 23, 2026 19:19
@wpmobilebot

wpmobilebot commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 1a4e892 vs trunk

app-size

Metric trunk 1a4e892 Diff Change
App Size (Mac) 1237.57 MB 1237.57 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 1a4e892 Diff Change
load 1970 ms 1966 ms 4 ms ⚪ 0.0%

site-startup

Metric trunk 1a4e892 Diff Change
siteCreation 6048 ms 7055 ms +1007 ms 🔴 16.7%
siteStartup 3941 ms 3939 ms 2 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks for the fix 👍

@bcotrim

bcotrim commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Fixed with #2871

@bcotrim bcotrim closed this Mar 23, 2026
@bcotrim
bcotrim deleted the fix-trunk-lint branch April 20, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants