Fix typecheck errors in AI skills handlers after config split - #2877
Closed
bcotrim wants to merge 2 commits into
Closed
Fix typecheck errors in AI skills handlers after config split#2877bcotrim wants to merge 2 commits into
bcotrim wants to merge 2 commits into
Conversation
Collaborator
📊 Performance Test ResultsComparing 1a4e892 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
approved these changes
Mar 23, 2026
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look good, thanks for the fix 👍
Contributor
Author
|
Fixed with #2871 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI identified the root cause (config split removed
sitesfromUserData) and applied the fix usingSiteServer.getAllDetails().Proposed Changes
loadUserData().siteswithSiteServer.getAllDetails()in three AI skills IPC handlers (getWordPressSkillsStatusAllSites,installWordPressSkillsToAllSites,removeWordPressSkillFromAllSites) that broke after the decoupled config file strategy was merged.Testing Instructions
npm run typecheck— should pass with no errorsnpm test -- apps/studio/src/tests/ipc-handlers.test.ts— all tests should passPre-merge Checklist