Skip to content

Studio: Update php-wasm ( playground dependecies) - #491

Merged
kozer merged 20 commits into
trunkfrom
update-playground
Aug 30, 2024
Merged

Studio: Update php-wasm ( playground dependecies)#491
kozer merged 20 commits into
trunkfrom
update-playground

Conversation

@kozer

@kozer kozer commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Fixes https://github.com/Automattic/dotcom-forge/issues/8867

Proposed Changes

This PR updates the following packages to the latest version:

  • @php-wasm/node
  • @php-wasm/universal
  • @php-wasm/scopes
  • @wp-playground/blueprints

During the update we ran into various issues, some of which required changes in the wordpress-playground repository:

  • Fix issue with types definitions that were missing
  • Fix issue with websocket proxy server not closing when a phpruntime is exited.

We had to change a couple of things in the current implementation of wp-now within Studio as it was relying on outdated APIs. These changes mainly relate to how we obtain a PHP instance.

Testing Instructions

  • Try running the app on MacOS and Windows
  • We should ideally systematically go over the list of smoke tests to ensure that this update did not break anything that was previously working.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@kozer
kozer marked this pull request as draft August 27, 2024 14:08
@jeroenpf
jeroenpf marked this pull request as ready for review August 29, 2024 11:16
@kozer
kozer requested a review from a team August 29, 2024 14:02
@kozer

kozer commented Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

Things I have tested:

  • Import / Export
  1. Import Jetpack backup
  2. Export Site
  3. Import Studio backup
  4. Export database
  • AI Assistant
  1. Context works
    image
  • Behavior of app ( not feature related )
  1. Add site works.
  2. Delete site works
  3. Change PHP version works
  4. Add site from onboarding works

cc: @jeroenpf @katinthehatsite

@katinthehatsite

Copy link
Copy Markdown
Contributor

I smoke tested the app with the build from this branch and everything worked as expected. The only thing that I noticed is that this branch is about 20 - 30 seconds slower for me when importing a database. Steps to reproduce:

  • Export a database from a Studio site
  • Import a database into the same Studio site
  • Comparing it to the trunk, the trunk looks faster by about 20 seconds. The import / export does complete successfully though

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smoke tested the app, tried several different plugins and themes and everything is running as expected for me 👍

I noticed that sometimes importing could be slower compared to trunk but I was not able to reproduce this consistently so I am suspecting that it might be a specific import file at fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants