Skip to content

Fix Playground rewrite rules - #505

Merged
sejas merged 4 commits into
trunkfrom
fix/playground-rewriterules
Sep 3, 2024
Merged

Fix Playground rewrite rules#505
sejas merged 4 commits into
trunkfrom
fix/playground-rewriterules

Conversation

@sejas

@sejas sejas commented Sep 3, 2024 •
edited by katinthehatsite
Loading

Copy link
Copy Markdown
Member

Proposed Changes

  • Add wordPressRewriteRules from @wp-playground/wordpress

Kudos to the whole @Automattic/yolo team for finding and fixing the issue.

Testing Instructions

  • Run 'npm install && npm start'
  • Create a page and set the permalink in the settings, or import a site with that setting
  • Observe the page renders correctly instead of a "Not found" error.

about-me-w

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Sep 3, 2024
@sejas
sejas requested a review from a team September 3, 2024 10:13
fluiddot
fluiddot reviewed Sep 3, 2024
View reviewed changes
Comment thread src/hooks/use-i18n-data.tsx Outdated
fluiddot
fluiddot reviewed Sep 3, 2024
View reviewed changes
Comment thread vendor/wp-now/src/wp-now.ts Outdated
fluiddot
fluiddot approved these changes Sep 3, 2024
View reviewed changes

@fluiddot fluiddot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 ! I've confirmed that using non-plain permalink structures works as expected. Great work team @Automattic/yolo !
@sejas
sejas merged commit 9d747d0 into trunk Sep 3, 2024
@sejas
sejas deleted the fix/playground-rewriterules branch September 3, 2024 10:49
@katinthehatsite katinthehatsite mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sejas @fluiddot