Mount filesystems again when rotating PHP runtime instance - #519
Merged
Conversation
kozer
approved these changes
Sep 9, 2024
fluiddot
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #516
Proposed Changes
When rotating an instance, the callback used by the rotation logic should prepare the filesystem and mount the required directories again as they are not retained. Only MEMFS mounts are carried over to the fresh instance but we are using NODEFS for most mounts.
To achieve this, i extracted some logic out of the huge main function
startWPNowto make it reusable when creating the first instance AND during the rotation.Not all logic needs to be executed again. We only care about the mounts and PHP settings.
Testing Instructions
ab -n 500 http://localhost:<port>/npm startwhen request 400 has been reached, you should see a log output telling you the PHP instance is being rotated.Pre-merge Checklist