Skip to content

Mount filesystems again when rotating PHP runtime instance #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroenpf merged 3 commits into from
Sep 10, 2024
Merged

Mount filesystems again when rotating PHP runtime instance #519

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62eee3e
Mount filesystems again when rotating PHP runtime instance
jeroenpf Sep 9, 2024
056658c
Enable proxyFileSystem again
jeroenpf Sep 9, 2024
033af2b
Remove tab
jeroenpf Sep 9, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 66 additions & 46 deletions vendor/wp-now/src/wp-now.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,18 @@ export default async function startWPNow(
const { documentRoot } = options;
const requestHandler = new PHPRequestHandler({
phpFactory: async ({ isPrimary, requestHandler:reqHandler }) => {
const id = await loadNodeRuntime( options.phpVersion );
const php = new PHP(id);
if( reqHandler ) {
php.requestHandler = reqHandler
}
const { php } = await getPHPInstance( options, isPrimary, reqHandler );
if(!isPrimary) {
proxyFileSystem(await requestHandler.getPrimaryPhp(), php, [
'/tmp',
requestHandler.documentRoot,
'/internal/shared',
]);
proxyFileSystem(await requestHandler.getPrimaryPhp(), php, [
'/tmp',
requestHandler.documentRoot,
'/internal/shared',
]);
}
if( reqHandler ) {
php.requestHandler = reqHandler
}
await setPhpIniEntries(php, {
'memory_limit': '256M',
'disable_functions': '',
'allow_url_fopen': '1',
'openssl.cafile': '/internal/shared/ca-bundle.crt'
});

return php;
},
documentRoot: documentRoot || '/wordpress',
Expand All @@ -68,15 +62,7 @@ export default async function startWPNow(

const php = await requestHandler.getPrimaryPhp()

php.mkdir(documentRoot);
php.chdir(documentRoot);
php.writeFile(
`${documentRoot}/index.php`,
`<?php echo 'Hello wp-now!';`
);
php.writeFile(
'/internal/shared/ca-bundle.crt', rootCertificates.join('\n')
)
prepareDocumentRoot( php, options );

output?.log(`directory: ${options.projectPath}`);
output?.log(`mode: ${options.mode}`);
Expand All @@ -102,26 +88,7 @@ export default async function startWPNow(

const isFirstTimeProject = !fs.existsSync(options.wpContentPath);

switch (options.mode) {
case WPNowMode.WP_CONTENT:
await runWpContentMode(php, options);
break;
case WPNowMode.WORDPRESS_DEVELOP:
await runWordPressDevelopMode(php, options);
break;
case WPNowMode.WORDPRESS:
await runWordPressMode(php, options);
break;
case WPNowMode.PLUGIN:
await runPluginOrThemeMode(php, options);
break;
case WPNowMode.THEME:
await runPluginOrThemeMode(php, options);
break;
case WPNowMode.PLAYGROUND:
await runWpPlaygroundMode(php, options);
break;
}
await prepareWordPress(php, options);

if (options.blueprintObject) {
output?.log(`blueprint steps: ${options.blueprintObject.steps.length}`);
Expand All @@ -147,7 +114,11 @@ export default async function startWPNow(
php,
cwd: requestHandler.documentRoot,
recreateRuntime: async () => {
return await loadNodeRuntime(options.phpVersion)
output?.log('Recreating and rotating PHP runtime');
const { php, runtimeId } = await getPHPInstance( options, true, requestHandler );
prepareDocumentRoot( php, options );
await prepareWordPress( php, options );
return runtimeId;
},
maxRequests: 400,
});
Expand All @@ -158,6 +129,55 @@ export default async function startWPNow(
};
}

async function getPHPInstance( options: WPNowOptions, isPrimary: boolean, requestHandler: PHPRequestHandler ) : Promise<{ php: PHP; runtimeId: number }> {
const id = await loadNodeRuntime( options.phpVersion );
const php = new PHP(id);

await setPhpIniEntries(php, {
'memory_limit': '256M',
'disable_functions': '',
'allow_url_fopen': '1',
'openssl.cafile': '/internal/shared/ca-bundle.crt'
});

return { php, runtimeId: id };
}

function prepareDocumentRoot( php: PHP, options: WPNowOptions ) {
php.mkdir(options.documentRoot);
php.chdir(options.documentRoot);
php.writeFile(
`${options.documentRoot}/index.php`,
`<?php echo 'Hello wp-now!';`
);
Comment thread
fluiddot marked this conversation as resolved.
php.writeFile(
'/internal/shared/ca-bundle.crt', rootCertificates.join('\n')
)
}

async function prepareWordPress( php: PHP, options: WPNowOptions ) {
switch (options.mode) {
case WPNowMode.WP_CONTENT:
await runWpContentMode(php, options);
break;
case WPNowMode.WORDPRESS_DEVELOP:
await runWordPressDevelopMode(php, options);
break;
case WPNowMode.WORDPRESS:
await runWordPressMode(php, options);
break;
case WPNowMode.PLUGIN:
await runPluginOrThemeMode(php, options);
break;
case WPNowMode.THEME:
await runPluginOrThemeMode(php, options);
break;
case WPNowMode.PLAYGROUND:
await runWpPlaygroundMode(php, options);
break;
}
}

async function runIndexMode(
php: PHP,
{ documentRoot, projectPath }: WPNowOptions
Expand Down