Studio: Update import/export messaging and tooltips when sync is in progress - #717
Conversation
|
@ivan-ottinger Could we do the same for the Disconnect, Push, and Pull buttons? |
Looks like @katinthehatsite is already graying out the It would leave this PR focused on the changes on the Import / Export tab. What do you think, Kat and Wojtek? 🙂 |
|
Sounds good @ivan-ottinger , let's handle that under the other PR. |
sejas
left a comment
There was a problem hiding this comment.
Looks good!
I've found a small bug where we display the Sync tooltip in the drop down area when we should display a new message mentioning the site is being exported.
<Tooltip className={ 'w-full' } text={ siteSyncingMessage() } disabled={ ! disabled }>
I left other comments/suggestions, but they’re not strong opinions—feel free to make any decision you think is best.
Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com>
| const isImporting = importState[ selectedSite.id ]?.progress < 100; | ||
| const isExportDisabled = isImporting || isAnySiteSyncing; | ||
|
|
||
| let tooltipText; |
There was a problem hiding this comment.
If the tooltip text isn't provided, the Tooltip component will make sure the tooltip gets hidden: #722 (I have separated the Tooltip component fix into its own PR).
Related issues
Proposed Changes
The proposed changes improve the user experience on the
Import/Exporttab when sync (push or pull) or import operation is in progress. The changes include:Export entire siteandExport databasebuttons → Now there's just one tooltip for both buttonsTesting Instructions
npm start.Pre-merge Checklist