Skip to content

Studio: Hide tooltip if the provided text is not available - #722

Merged
ivan-ottinger merged 2 commits into
trunkfrom
fix/tooltip-to-hide-when-no-text
Dec 9, 2024
Merged

Studio: Hide tooltip if the provided text is not available#722
ivan-ottinger merged 2 commits into
trunkfrom
fix/tooltip-to-hide-when-no-text

Conversation

@ivan-ottinger

@ivan-ottinger ivan-ottinger commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • hide tooltip if the provided text is not available

Testing Instructions

  1. Check out the PR branch and build the app with npm start.
  2. Wait for Studio: Update import/export messaging and tooltips when sync is in progress #717 to be merged.
  3. Initiate a sync of one of the connected sites and head over to the Import / Export tab.
  4. Hover over the "Drag file" or export button to see the tooltip. Keep the cursor there.
  5. As soon as the syncing finishes, the tooltip should disappear automatically.
  6. Review other existing Studio app tooltips. There should be no regression.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger
ivan-ottinger requested a review from a team December 6, 2024 16:40
@ivan-ottinger

Copy link
Copy Markdown
Contributor Author

This PR is ready for review and is easiest to be tested once #717 has been merged.

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected, but I needed to rebase this branch on trunk.

@ivan-ottinger

Copy link
Copy Markdown
Contributor Author

It works as expected, but I needed to rebase this branch on trunk.

Thanks for the review, Wojtek. Yes, I missed adding that step into the testing instructions.

@ivan-ottinger
ivan-ottinger merged commit fb88212 into trunk Dec 9, 2024
@ivan-ottinger
ivan-ottinger deleted the fix/tooltip-to-hide-when-no-text branch December 9, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants