feat(giskard-llm): pass through provider transport config - #2486
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom transport configurations across all LLM providers, allowing users to pass a caller-owned http_client and default_headers to the underlying SDKs. The changes include updates to the README documentation with usage examples, modifications to the provider classes (OpenAI, Azure, Anthropic, and Google) to handle these new parameters, and the addition of comprehensive unit tests to verify correct forwarding of the transport settings. I have no feedback to provide as there were no review comments.
…tion in AzureAIProvider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_clientanddefault_headersthrough giskard-llm providers to their native SDK clients.google.genai.types.HttpOptions, preserving explicithttp_optionsfields over convenience kwargs.Notes
azure_ai/still usesAsyncAzureOpenAI, keeps/modelsstripping, and keeps the existingAZURE_AI_API_VERSIONdefault behavior.http_clientis caller-owned and is not closed by giskard-llm.ssl_verify,default_query,max_retries, or Azure AI Foundry OpenAI v1 behavior.Test plan
uv run --extra all pytest tests/test_providers.py tests/test_routing.py -quv run ruff check .uv run ruff format --check .