docs(giskard-llm): document Azure Foundry v1 via OpenAI - #2487
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for Azure Foundry OpenAI v1 endpoints by updating documentation and adding unit tests for routing and provider configuration. The changes ensure these OpenAI-compatible endpoints are correctly handled by the LLMClient. Feedback was provided to improve the formatting of a code example in the README for better consistency.
| "foundry-v1/gpt-4.1-mini", | ||
| [{"role": "user", "content": "Write one sentence."}], | ||
| ) | ||
| response = await client.aresponse("foundry-v1/gpt-4.1-mini", "Write one sentence.") |
Contributor
There was a problem hiding this comment.
For better readability and consistency with the other calls in this example, consider adding a blank line after this line.
Suggested change
| response = await client.aresponse("foundry-v1/gpt-4.1-mini", "Write one sentence.") | |
| response = await client.aresponse("foundry-v1/gpt-4.1-mini", "Write one sentence.") | |
Hartorn
force-pushed
the
docs/azure-foundry-v1-openai-provider
branch
from
May 22, 2026 08:28
40a0cf3 to
5738c98
Compare
kevinmessiaen
previously approved these changes
May 28, 2026
kevinmessiaen
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider="openai"./openai/v1/base URLs without Azureapi_version.azure_foundry_v1functional CI slice that reuses the existing Azure AI CI credentials and derives the OpenAI v1 base URL fromAZURE_AI_ENDPOINT.Tests
uv run --extra all pytest tests/test_providers.py tests/test_routing.py -quv run pytest --collect-only tests/functional -m "functional and azure_foundry_v1" -quv run ruff check .uv run ruff format --check .Notes
This is stacked on #2486 because it documents and tests the transport/configuration path added there. It intentionally leaves
azure_ai/behavior unchanged.