Fix Project-Settings, Fix Compile Errors and improvement for Cleanup for Offline Players and NPCs#165
Merged
Jimmacle merged 3 commits intoTorchAPI:masterfrom Jul 22, 2020
Merged
Conversation
For whatever reason unknown to me the path for Nlog was broken for me. VS was unable to load it in. Since it does not seem to reference anything available on my PC I assume that one is broken. Now it also uses the TorchBinaries.
Does not seem to be a thing many people use because its been broken for quite a while now... Luckily was just a simple rename
GetPlayer only returns online players and never NPCs. which is bad. Since we only take the IdentityID anyway we can just ask for the Identity either by name, identity ID or steam ID even.
Jimmacle
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title sais, NLog.dll was referenced to whatever location but not using the TorchBinaries. So on my system it didnt work.
Keen renamed RequestBalanceChange to ChangeBalance which is broken in the current version (about all !econ commands)
And !cleanup list ownedby did ignore NPC names, or names of offline players which is not so great.