Dylan search function by DylanAustin-TheDreamer · Pull Request #648 · buddhist-uni/buddhist-uni.github.io

DylanAustin-TheDreamer · 2026-04-11T14:33:02Z

Added the ability to check one words against database titles.

culasaccakasutta will fetch -> MN 35 Cūḷa Saccaka Sutta: The Shorter Discourse With Saccaka

The function comes with an extensive regex for parsing both the store object titles and user queries.

It is a good start on this issue, and it keeps people engaged with the site I hope.

…hist-uni.github.io into dylan-search-function

netlify · 2026-04-11T14:33:07Z

✅ Deploy Preview for obu ready!

Name	Link
🔨 Latest commit	`a2d8a89`
🔍 Latest deploy log	https://app.netlify.com/projects/obu/deploys/69ef290534d59b000752264a
😎 Deploy Preview	https://deploy-preview-648--obu.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

khemarato

Okay. A good start! Comments inline.

khemarato · 2026-04-12T06:29:53Z

      });
    });
  }
+  finalResults = tokenResults.length ? tokenResults : results;


Only run findOneWordTitleMatches if the normal search returns no results and there is sutta in the query.

khemarato · 2026-04-12T06:34:00Z

+  for (var i in store){
+    const item = store[i];
+    const title = (item && item.title) ? item.title : "";
+    const titleMatch = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|SNP|DHP|ITI|THAG|THIG|UD)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/(\bsutta\b).*$/i, "$1").toLowerCase().replace(/[^a-z0-9]/g, "");


Split this normalization off into a function and add tests for it showing how you expect it to work. Then use that function to precompute these normalized strings in the index build. This will make searched faster and will all us to inspect the normalized strings for errors.

khemarato · 2026-04-12T06:35:07Z

 var BMAX = 250; // Max blurb size in characters
 var RMAX = 100; // Max number of results to display

+const suttaFinder = '<a href="https://name.readingfaithfully.org/" class="btn" target="_blank">Sutta Finder</a>'


remove this unused variable.

khemarato · 2026-04-12T06:36:04Z

    }
 }

+function findOneWordTitleMatches(query, store) {


Let's rename this to findOneWordSuttaTitleMatches to make it clear it's only looking at Pāli suttas

khemarato · 2026-04-13T02:33:46Z

      });
    });
  }
+  finalResults = results.length ? results : tokenResults = findOneWordSuttaTitleMatches(data.q.trim(), store);


Why are you calling findOneWordSuttaTitleMatches twice?

khemarato · 2026-04-13T02:34:21Z

+function findOneWordSuttaTitleMatches(query, store) {
+  var tokenResults = [];
+  const normalizedQuery = query.normalize("NFD").replace(/[\u0300-\u036f]/g, "").toLowerCase().replace(/[^a-z0-9]/g, "");
+  for (var i in store){


This loop should be done at index build not on message reply.

… store items with new normalized titles

…hist-uni.github.io into dylan-search-function

…om/DylanAustin-TheDreamer/buddhist-uni.github.io into dylan-search-function

khemarato

Okay. This is getting quite close to merge-worthy. Will take a closer look at your parsing logic tomorrow.

khemarato · 2026-04-15T09:19:45Z

    }
 });

+joinedTitles = normalizeSuttaTitles(store);


Oh yeah. That's what I meant! You got it 🙂

DylanAustin-TheDreamer · 2026-04-15T09:36:18Z

yay!

…

On Wed, Apr 15, 2026 at 10:22 AM Khemarato Bhikkhu ***@***.***> wrote: ***@***.**** commented on this pull request. Okay. This is getting quite close to merge-worthy. Will take a closer look at your parsing logic tomorrow. ------------------------------ In assets/js/search_index.js <#648 (comment)> : > @@ -69,6 +69,8 @@ var idx = lunr(function () { } }); +joinedTitles = normalizeSuttaTitles(store); Oh yeah. That's what I meant! You got it 🙂 — Reply to this email directly, view it on GitHub <#648 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJCKZITWIRVKDHSQV5RYES34V5IFBAVCNFSM6AAAAACXU77VDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCMJSGM2DCMJVGE> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

khemarato · 2026-04-15T12:21:25Z

+    const item = obj[i];
+    if (!item || item.type !== "content" || item.category !== "canon") continue;
+    const title = item.title || "";
+    const titleJoin = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|SNP|DHP|ITI|THAG|THIG|UD)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/(\bsutta\b).*$/i, "$1").toLowerCase().replace(/[^a-z0-9]/g, "");


So right now, there are some bugs with this function, for a quick sampling:

ma220 is right now returning ma220aritthasutrathediscourseonknowingthebetterwaytocatchasnake when it should be aritthasutra

ma128 is giving ma128upasakasutradiscourseonthewhitecladdisciple instead of upasakasutra

thequestionsofkingmalindaanabridgementofthemilindapanha should probably be skipped

themahasatipatthanasutta and theuppatipatikasutta and theyogasutra shouldn't include the the at the beginning

The Thig / Thag entries are not working right. For example: subhajivakambavanikatherigathasubhaofjivakasmangogrove or punnatherigathapunnika

for ma80, we should just filter it out instead of giving ma80theroughcloth

lal26 has lal26dharmacakrapravartanasutrathediscoursethatsetthedharmawheelrolling instead of dharmacakrapravartanasutra

Add tests for these cases and fix the implementation so that these cases pass. In our call tomorrow morning, I can show you how I found these.

DylanAustin-TheDreamer · 2026-04-15T12:33:17Z

perfect I will document this and I look forward to our meeting. Thank you for your time - (this one is a tough cookie but I'll get there)

…

On Wed, Apr 15, 2026 at 1:21 PM Khemarato Bhikkhu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In assets/js/search_functions.js <#648 (comment)> : > @@ -1,6 +1,24 @@ // Parameters var BMAX = 250; // Max blurb size in characters var RMAX = 100; // Max number of results to display +var joinedTitles = [] + +function normalizeSuttaTitles (obj) { + var joinedTitleDatabase = [] + + for (var i in obj){ + const item = obj[i]; + if (!item || item.type !== "content" || item.category !== "canon") continue; + const title = item.title || ""; + const titleJoin = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|SNP|DHP|ITI|THAG|THIG|UD)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/(\bsutta\b).*$/i, "$1").toLowerCase().replace(/[^a-z0-9]/g, ""); So right now, there are some bugs with this function, for a quick sampling: - ma220 is right now returning ma220aritthasutrathediscourseonknowingthebetterwaytocatchasnake when it should be aritthasutra - ma128 is giving ma128upasakasutradiscourseonthewhitecladdisciple instead of upasakasutra - thequestionsofkingmalindaanabridgementofthemilindapanha should probably be skipped - themahasatipatthanasutta and theuppatipatikasutta and theyogasutra shouldn't include the the at the beginning - The Thig / Thag entries are not working right. For example: subhajivakambavanikatherigathasubhaofjivakasmangogrove or punnatherigathapunnika - for ma80, we should just filter it out instead of giving ma80theroughcloth - lal26 has lal26dharmacakrapravartanasutrathediscoursethatsetthedharmawheelrolling instead of dharmacakrapravartanasutra Add tests for these cases and fix the implementation so that these cases pass. In our call tomorrow morning, I can show you how I found these. — Reply to this email directly, view it on GitHub <#648 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJCKZIWJDSSPTKVZP7ICEUL4V55F3AVCNFSM6AAAAACXU77VDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCMJTGQ3TINRQHE> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

…hist-uni.github.io into dylan-search-function

…te: remove all text after : for scale

…hist-uni.github.io into dylan-search-function

…w my feature works

khemarato

Getting close! 😸

khemarato · 2026-04-24T10:07:29Z

+    assert.equal(result[0].title, 'upasakasutra');
+  });
+
+  it('integrated more nikaya indexes for parsing - lets test lal', () => {


the it() strings are supposed to read like an English sentence. Obviously that's not required by the machine. It doesn't care. But as a courtesy to your human readers (in this case, me), the it() string should describe the behavior your test addresses as if you were speaking to them (which, of course, you are).

To quote the programming "bible":

a computer language is not just a way of getting a computer to perform operations but rather it is a novel formal medium for expressing ideas about methodology. Thus, programs must be written for people to read, and only incidentally for machines to execute.

khemarato · 2026-04-24T10:20:54Z

+    assert.equal(result[0].title, 'culasaccakasutta');
+  });
+
+  it('remove words after sutta and sutra but using : as a reference', () => {


This test is just testing sutra and you don't need to mention the implementation details. You just describe what you are testing. In this case, I'd just say 'also handles sutras'

khemarato · 2026-04-24T10:22:19Z

+    assert.equal(result[0].title, 'dharmacakrapravartanasutra');
+  });
+
+  it('it returns a joined title from a thig nikaya leading discourse', () => {


'can parse Therigathas'

khemarato · 2026-04-24T10:22:54Z

+    assert.equal(result[0].title, 'bhalliyatheragatha');
+  });
+
+  it('handles "the" and removes it from a string if it appears at the beginning', () => {


👍 Great!

khemarato · 2026-04-24T10:34:45Z

+    const title = item.title || "";
+      const titleJoin = title.normalize("NFD").replace(/[\u0300-\u036f]/g, "").replace(/^\s*(?:DN|MN|SN|AN|KN|LAL|DA|MA|SA|EA|SNP|DHP|ITI|THAG|THIG|UD|NIDD|CV|BV|AP|JA|PV|VV|KP|PTS)\s*\d+(?:\.\d+)?\s*[:.-]?\s*/i, "").replace(/\s*[:\-–]\s*.*$/, "").toLowerCase().replace(/[^a-z0-9]/g, "");
+      const removedTheOnJoin = titleJoin.replace(/^\s*(?:the)\s*/i, "");
+      joinedTitleDatabase.push({


For filtering out the non-sanskrit/pali titles, you could probably just add a test here, something like if(removedTheOnJoin.includes('sutta') || removedTheOnJoin.includes('sutra') || removedTheOnJoin.includes('gatha')) { then .push({ This will make sure we aren't adding anything that doesn't have one of the "approved" name types.

…hist-uni.github.io into dylan-search-function

khemarato

Okay. Just a few minor nits on the test cases and then this is good to merge :)

khemarato · 2026-04-27T01:46:58Z

  });

-  it('integrated more nikaya indexes for parsing - lets test lal', () => {
+  it('handles the filtering out of a wide range of nikaya indexes', () => {


This test doesn't test a wide range of nikaya indexes. The test is fine, but say what it tests. It tests that it can parse a Lal sutra.

khemarato · 2026-04-27T02:03:29Z

      id1: {
-        title: 'DN 22 The Mahāsatipaṭṭhāna Sutta: The Long Discourse about the Ways of Attending to Mindfulness',
+        title: 'Audio/Video',
+        type: 'av',


av is category not a type. It still has type: 'content'. Also, to make this test truly a test of this filter, you have to give it a title that looks like a sutta!

…hist-uni.github.io into dylan-search-function

khemarato · 2026-04-27T09:08:08Z

  });

-  it('handles the filtering out of a wide range of nikaya indexes', () => {
+  it('tests that it can parse a lal sutra', () => {


The it is describing the function being tested 😅 it('can parse a lal sutra', We know it's a test already!

…hist-uni.github.io into dylan-search-function

DylanAustin-TheDreamer · 2026-04-27T09:42:17Z

oh my..... took 3 years but we got it!

…

On Mon, Apr 27, 2026 at 10:41 AM Khemarato Bhikkhu ***@***.***> wrote: Merged #648 <#648> into main. — Reply to this email directly, view it on GitHub <#648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BJCKZISYBUU2PNBQDG7AIL34X4TNBAVCNFSM6AAAAACXU77VDWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRUHA4TSNJVGM4TQMY> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: <buddhist-uni/buddhist-uni.github.io/pull/648/issue_event/24899553983@ github.com>

khemarato · 2026-04-27T09:43:31Z

Congratulations 😊

DylanAustin-TheDreamer added 11 commits March 24, 2026 15:34

Add: oneword token search based on the search patter we use

d0ec6da

removed: line reference comments

4f966ff

add: sutta finder variable at the top for one word query

8643466

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

5d5d6c8

…hist-uni.github.io into dylan-search-function

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

d86b787

…hist-uni.github.io into dylan-search-function

create: onewordtoken function and TDD - first failed now passes

1860aa4

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

76b34f9

…hist-uni.github.io into dylan-search-function

trying to get item titles from results array of objects

26eff64

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

fd5e9db

…hist-uni.github.io into dylan-search-function

add: fallback for oneword search results back to results on no results

e799cbc

add: findoneword function in completed form with TDD

c6f4827

khemarato reviewed Apr 12, 2026

View reviewed changes

add: new normalizetitle function and better results handling

c0649bc

khemarato reviewed Apr 13, 2026

View reviewed changes

DylanAustin-TheDreamer added 3 commits April 13, 2026 22:01

update: findoneword...() with matching against joinedTitles made from…

703e8c9

… store items with new normalized titles

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

2c16c89

…hist-uni.github.io into dylan-search-function

Merge branches 'dylan-search-function' and 'main' of https://github.c…

c0be5b6

…om/DylanAustin-TheDreamer/buddhist-uni.github.io into dylan-search-function

khemarato reviewed Apr 15, 2026

View reviewed changes

DylanAustin-TheDreamer added 6 commits April 16, 2026 08:10

add: new test cases to normalizeSuttaTitles

2905284

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

55cb72e

…hist-uni.github.io into dylan-search-function

add: remove the from beginning, better nikaya index handling and upda…

24d19d6

…te: remove all text after : for scale

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

77e02b5

…hist-uni.github.io into dylan-search-function

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

549d6c4

…hist-uni.github.io into dylan-search-function

add: several test cases to match cases suggested on PR review, to sho…

a50ba3c

…w my feature works

khemarato reviewed Apr 24, 2026

View reviewed changes

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

8a653f6

…hist-uni.github.io into dylan-search-function

DylanAustin-TheDreamer added 2 commits April 25, 2026 20:25

Add: extra test cases and new normalizeSuttaTitles() handling

332e7e5

remove: un-used tokenResults variable

d9b6d97

khemarato approved these changes Apr 27, 2026

View reviewed changes

DylanAustin-TheDreamer added 2 commits April 27, 2026 07:37

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

8907d60

…hist-uni.github.io into dylan-search-function

update: test case names to match test cases properly

49dd5cd

khemarato reviewed Apr 27, 2026

View reviewed changes

DylanAustin-TheDreamer added 2 commits April 27, 2026 09:11

Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…

cf14f49

…hist-uni.github.io into dylan-search-function

update: test case description for testing parse lal sutra

a2d8a89

khemarato merged commit dee7f08 into buddhist-uni:main Apr 27, 2026
4 checks passed

khemarato mentioned this pull request Apr 27, 2026

Searching for *sutta should work better #79

Closed

Conversation

DylanAustin-TheDreamer commented Apr 11, 2026

netlify Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for obu ready!

khemarato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

khemarato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanAustin-TheDreamer commented Apr 15, 2026 via email

Choose a reason for hiding this comment

DylanAustin-TheDreamer commented Apr 15, 2026 via email

khemarato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

khemarato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

khemarato Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanAustin-TheDreamer commented Apr 27, 2026 via email

khemarato commented Apr 27, 2026

Labels

2 participants

netlify Bot commented Apr 11, 2026 •

edited

Loading

khemarato Apr 27, 2026 •

edited

Loading