-
Notifications
You must be signed in to change notification settings - Fork 16
Dylan search function #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khemarato
merged 28 commits into
buddhist-uni:main
from
DylanAustin-TheDreamer:dylan-search-function
Apr 27, 2026
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d0ec6da
Add: oneword token search based on the search patter we use
DylanAustin-TheDreamer 4f966ff
removed: line reference comments
DylanAustin-TheDreamer 8643466
add: sutta finder variable at the top for one word query
DylanAustin-TheDreamer 5d5d6c8
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer d86b787
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 1860aa4
create: onewordtoken function and TDD - first failed now passes
DylanAustin-TheDreamer 76b34f9
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 26eff64
trying to get item titles from results array of objects
DylanAustin-TheDreamer fd5e9db
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer e799cbc
add: fallback for oneword search results back to results on no results
DylanAustin-TheDreamer c6f4827
add: findoneword function in completed form with TDD
DylanAustin-TheDreamer c0649bc
add: new normalizetitle function and better results handling
DylanAustin-TheDreamer 703e8c9
update: findoneword...() with matching against joinedTitles made from…
DylanAustin-TheDreamer 2c16c89
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer c0be5b6
Merge branches 'dylan-search-function' and 'main' of https://github.c…
DylanAustin-TheDreamer 2905284
add: new test cases to normalizeSuttaTitles
DylanAustin-TheDreamer 55cb72e
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 24d19d6
add: remove the from beginning, better nikaya index handling and upda…
DylanAustin-TheDreamer 77e02b5
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 549d6c4
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer a50ba3c
add: several test cases to match cases suggested on PR review, to sho…
DylanAustin-TheDreamer 8a653f6
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 332e7e5
Add: extra test cases and new normalizeSuttaTitles() handling
DylanAustin-TheDreamer d9b6d97
remove: un-used tokenResults variable
DylanAustin-TheDreamer 8907d60
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer 49dd5cd
update: test case names to match test cases properly
DylanAustin-TheDreamer cf14f49
Merge branch 'main' of https://github.com/DylanAustin-TheDreamer/budd…
DylanAustin-TheDreamer a2d8a89
update: test case description for testing parse lal sutra
DylanAustin-TheDreamer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update: findoneword...() with matching against joinedTitles made from…
… store items with new normalized titles
- Loading branch information
commit 703e8c91c3cb1d8598a6d77f4f9986ea47dd7d7e
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,8 @@ var idx = lunr(function () { | |
| } | ||
| }); | ||
|
|
||
| joinedTitles = normalizeSuttaTitles(store); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah. That's what I meant! You got it 🙂 |
||
|
|
||
| self.onmessage = function(e) { | ||
| self.postMessage(handleSearchMessage(e.data, idx.search.bind(idx))); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So right now, there are some bugs with this function, for a quick sampling:
ma220aritthasutrathediscourseonknowingthebetterwaytocatchasnakewhen it should bearitthasutrama128upasakasutradiscourseonthewhitecladdiscipleinstead ofupasakasutrathequestionsofkingmalindaanabridgementofthemilindapanhashould probably be skippedthemahasatipatthanasuttaandtheuppatipatikasuttaandtheyogasutrashouldn't include thetheat the beginningsubhajivakambavanikatherigathasubhaofjivakasmangogroveorpunnatherigathapunnikama80theroughclothlal26dharmacakrapravartanasutrathediscoursethatsetthedharmawheelrollinginstead ofdharmacakrapravartanasutraAdd tests for these cases and fix the implementation so that these cases pass. In our call tomorrow morning, I can show you how I found these.