[WEB-537] fix: issue in all-issue create view modal, filter needs to disappear when filter is de selected. #3781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disappear when filter is de selected.
prateekshourya29
requested review from
pushya22,
rahulramesha and
sriramveeraghanta
rahulramesha
approved these changes
Feb 23, 2024
sriramveeraghanta
approved these changes
Feb 23, 2024
aaryan610
pushed a commit
that referenced
this pull request
Sep 30, 2025
* [SILO-404] [SILO-425] [SILO-427] Get fields to display API for work item create form + project config + options method (#3781) * plane client v2 using node sdk + form fields API * add form utils methods for project config and options * update plane-node-sdk and bug fixes * [SILO-427] Add support for custom field options in options api (#3849) * add support for custom field options in options api * make flexible params for custom fields * remove unused types * removed issue type in get intake * remove options in custom fields fetch + add typeId in custom fieldId * remove options in labels and states fields * add caching and search text support in options api * add tests for fields options method * [SILO-424] [SILO-415] feat: slack linkbacks revamp and modal changes to include intake in work item (#3841) * fix: added new issue linkback * fix: member endpoint to not return bot users * feat: added helpers for supporting functions * fix: added old value field for activity to show in the linkback * feat: create new activity and comment linkback * feat: refactored existing views according to new designs * feat: refactored workers to comply with new views * fix: added helper function for inverting map * fix: self review suggestions * fix: resolved review comments * [SILO-424] fix: revamped slack modals to include custom fields for work item creation (#3912) * fix: modified options api to use the latest fields api * fix: added field parser in order to parse slack form field values * fix: added helpers for slack * fix: added work item and modal props * fix: added activity update block * fix: made intake linkback less complex * fix: issue modal now supports custom field values * fix: added new block actions according to new modal action changes * fix: added create mode for message actions * fix: switched comment sync payload to helper functions * fix: reduced form fields for intake issue * chore: addressed review comments * fix: testing fixes for slack integration * fix: command linkback not working * fix: removed sync button for update modal * fix: added type expand support for work items * fix: modified sdk for adding type as an expanded field * fix: added check for type for unfurls * fix: self review 2 * fix: updated UX copy changes proposed * fix: resolved comments from review * [SILO-410] Pages link unfurl in Slack (#3894) * added page support in slack link unfurl * add support for page link unfurl in slack * move urls to constants + improvements * allow not required fields to be null * fix: block actions and project updates linkback * fix: type id parsing for form fields * fix: options api and module and cycle issues * fix: view submission and issue modal fixes * fix: removed unfurl media links * fix: added userid for the options api for slack * fix: slack comments got from testing * fix: removed yarn lock and slack block files --------- Co-authored-by: Henit Chobisa <chobisa.henit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The filers title are not disappearing when the filter is de selected. Also the remove filter button are not working. This is due to missing implementation of
handleRemoveFiltermethod.Solution
Filtered out the filters whose value not null or empty array in order to fix the title issue. Also added the implementation of
handleRemoveFiltermethod.Media
Before
scrnli_2_23_2024_5-25-07.PM.webm
After
scrnli_2_23_2024_5-24-07.PM.webm
This PR is linked to WEB-537