Skip to content

[WEB-663] fix: project members settings flickering #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sriramveeraghanta merged 1 commit into from
Mar 7, 2024
Merged

[WEB-663] fix: project members settings flickering #3894

sriramveeraghanta merged 1 commit into from
Mar 7, 2024

Conversation

@1akhanBaheti
Copy link
Member

@1akhanBaheti 1akhanBaheti commented Mar 7, 2024 •
edited
Loading

Problem:

  1. When either the project lead or default assignee is changed, the other property automatically changes to None for a blink.
  2. Default assignee & project lead container have slight differences in height when one of the property have value as None.

Solution:

  1. While updating project details, one of the property value was going as undefined, so fixed it by checking for its value in currentProjectDetails.
  2. Gave fixed height to both property container's.

Before:

project-members-settings-problem.mp4

After:

project-member-settings-solution.mp4

This PR is attached to WEB-663
@1akhanBaheti 1akhanBaheti added this to the v0.17.0-dev milestone Mar 7, 2024
@1akhanBaheti 1akhanBaheti self-assigned this Mar 7, 2024
@1akhanBaheti 1akhanBaheti changed the title fix: project members settings flickering Mar 7, 2024
@pushya22 pushya22 requested a review from rahulramesha March 7, 2024 07:04
@1akhanBaheti 1akhanBaheti requested a review from gurusainath March 7, 2024 07:04
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review March 7, 2024 07:04
@sriramveeraghanta sriramveeraghanta merged commit b03f6a8 into develop Mar 7, 2024
@sriramveeraghanta sriramveeraghanta deleted the fix/project-member-default-settings branch March 7, 2024 07:57
aaryan610 pushed a commit that referenced this pull request Sep 30, 2025
@Saurabhkmr98 @henit-chobisa
[SILO-402] Slack Integration v1 (#3952)
94fd553 
* [SILO-404] [SILO-425] [SILO-427] Get fields to display API for work item create form + project config + options method (#3781)

* plane client v2 using node sdk + form fields API

* add form utils methods for project config and options

* update plane-node-sdk and bug fixes

* [SILO-427]  Add support for custom field options in options api (#3849)

* add support for custom field options in options api

* make flexible params for custom fields

* remove unused types

* removed issue type in get intake

* remove options in custom fields fetch + add typeId in custom fieldId

* remove options in labels and states fields

* add caching and search text support in options api

* add tests for fields options method

* [SILO-424] [SILO-415] feat: slack linkbacks revamp and modal changes to include intake in work item (#3841)

* fix: added new issue linkback

* fix: member endpoint to not return bot users

* feat: added helpers for supporting functions

* fix: added old value field for activity to show in the linkback

* feat: create new activity and comment linkback

* feat: refactored existing views according to new designs

* feat: refactored workers to comply with new views

* fix: added helper function for inverting map

* fix: self review suggestions

* fix: resolved review comments

* [SILO-424] fix: revamped slack modals to include custom fields for work item creation (#3912)

* fix: modified options api to use the latest fields api

* fix: added field parser in order to parse slack form field values

* fix: added helpers for slack

* fix: added work item and modal props

* fix: added activity update block

* fix: made intake linkback less complex

* fix: issue modal now supports custom field values

* fix: added new block actions according to new modal action changes

* fix: added create mode for message actions

* fix: switched comment sync payload to helper functions

* fix: reduced form fields for intake issue

* chore: addressed review comments

* fix: testing fixes for slack integration

* fix: command linkback not working

* fix: removed sync button for update modal

* fix: added type expand support for work items

* fix: modified sdk for adding type as an expanded field

* fix: added check for type for unfurls

* fix: self review 2

* fix: updated UX copy changes proposed

* fix: resolved comments from review

* [SILO-410] Pages link unfurl in Slack (#3894)

* added page support in slack link unfurl

* add support for page link unfurl in slack

* move urls to constants + improvements

* allow not required fields to be null

* fix: block actions and project updates linkback

* fix: type id parsing for form fields

* fix: options api and module and cycle issues

* fix: view submission and issue modal fixes

* fix: removed unfurl media links

* fix: added userid for the options api for slack

* fix: slack comments got from testing

* fix: removed yarn lock and slack block files

---------

Co-authored-by: Henit Chobisa <chobisa.henit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend 🎨UI / UX

3 participants

@1akhanBaheti @sriramveeraghanta