fix(release): surface swallowed publish errors when stdout is not valid JSON - #35283
Merged
leosvelperez merged 1 commit intoApr 14, 2026
Merged
Conversation
…id JSON When `npm publish` or `pnpm publish` fails, the executor assumes `err.stdout` (always) contains valid JSON. If a lifecycle script (e.g. `prepublishOnly`) fails, it writes plaintext to stdout instead. This causes `JSON.parse` to throw and the actual error to be swallowed by the outer catch, printing only a generic "something unexpected went wrong" message. Wrap `JSON.parse(err.stdout...)` in a try/catch block. If parsing fails, fall back to logging raw stderr/stdout directly and return early, so lifecycle script failures and other non-JSON errors are always visible to the user. Fixes nrwl#34497
✅ Deploy Preview for nx-docs canceled.
|
✅ Deploy Preview for nx-dev canceled.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit f9ebd3c
☁️ Nx Cloud last updated this comment at |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When
npm publishorpnpm publishfails, the executor assumeserr.stdout(always) contains valid JSON. If a lifecycle script (e.g.prepublishOnly) fails, it writes plaintext to stdout instead. This causesJSON.parseto throw and the actual error to be swallowed by the outer catch, printing only a generic "something unexpected went wrong" message.Expected Behavior
Wrap
JSON.parse(err.stdout...)in a try/catch block. If parsing fails, fall back to logging raw stderr/stdout directly and return early, so lifecycle script failures and other non-JSON errors are always visible to the user.Related Issue(s)
Fixes #34497