Skip to content

fix(release): surface swallowed publish errors when stdout is not valid JSON #35283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leosvelperez merged 1 commit into from
Apr 14, 2026
Merged

fix(release): surface swallowed publish errors when stdout is not valid JSON #35283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/js/src/executors/release-publish/release-publish.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,18 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
};
}

const stdoutData = JSON.parse(err.stdout?.toString() || '{}');
// stdout is not guaranteed to be JSON (e.g. lifecycle script failures).
// If parsing fails, print raw stderr/stdout so the underlying error is visible to the user.
let stdoutData;
try {
stdoutData = JSON.parse(err.stdout?.toString() || '{}');
} catch {
console.error(err.stderr?.toString() || '');
console.error(err.stdout?.toString() || '');
return {
success: false,
};
}

console.error(`${pm} publish error:`);
// npm returns error.summary and error.detail
Expand Down
Loading