Skip to content

Recompiled basis, now works on IE #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slimbuck merged 4 commits into from
Feb 7, 2020
Merged

Recompiled basis, now works on IE #1865

slimbuck merged 4 commits into from
Feb 7, 2020

Conversation

@slimbuck
Copy link
Member

@slimbuck slimbuck commented Feb 7, 2020

The recompiled basis files include polyfill for Promise, required on IE browsers.

Also test for existence of performance.now() before using it (not present on IE).

NOTE: the generated asm.js file is twice the size :(

I confirm I have signed the Contributor License Agreement.
@slimbuck slimbuck requested a review from a team February 7, 2020 10:42
@slimbuck slimbuck merged commit 00071e4 into playcanvas:master Feb 7, 2020
@slimbuck slimbuck deleted the basis_update branch February 7, 2020 12:22
TheJonRobinson added a commit to Mojiworks/playcanvas-engine that referenced this pull request Feb 23, 2020
@TheJonRobinson
Merge branch 'master' into mojiworks/master
4946bdf 
* master: (31 commits)
  WebXR Input Sources (playcanvas#1873)
  Simplified constants definition in Math classes (playcanvas#1876)
  Improve batching to handle 8-bit and 32-bit index buffers (playcanvas#1872)
  Add particle start frame example to browser
  [FIX] Update WebXR examples to use latest enums (playcanvas#1870)
  [FIX] Add XRWebGLLayer to externs for Closure compiler (playcanvas#1869)
  update paths in the particle system start frame example (playcanvas#1868)
  add a animation start frame variable to the particle system which def… (playcanvas#1864)
  point cloud example using engine directly, and custom shader changing size and color of points (playcanvas#1867)
  WebXR Support (playcanvas#1834)
  Hardware Instancing fixes / sample (playcanvas#1846) (playcanvas#1856)
  [VERSION] v1.25.0-dev
  [RELEASE] v1.24.7
  Recompiled basis, now works on IE (playcanvas#1865)
  Small mesh cleanup (playcanvas#1866)
  [FIX] Revert memory-leak change (playcanvas#1862)
  [FIX] Flag model as immutable when it's added to a ModelComponent (playcanvas#1861)
  [FIX] Fix calculation of deprecated pc.MouseEvent#wheel (playcanvas#1859)
  [DOCS] Adjust Vec3.normalize docs to reflect behavior better (playcanvas#1849)
  pc.BatchManager.markGroupDirty is now public (playcanvas#1848)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@slimbuck @willeastcott @mvaligursky