Skip to content

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 27, 2026

After

we don't need the build id at runtime anymore when a deployment id is available.

Closes PACK-6756

Copy link
Member Author

mischnic commented Jan 27, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 27, 2026

Tests Passed

@mischnic mischnic changed the title WIP don't load build id if missing Jan 27, 2026
@nextjs-bot nextjs-bot added the Turbopack Related to Turbopack with Next.js. label Jan 27, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 27, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 464 MB 465 MB 🔴 +173 kB (+0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 457ms 457ms ▁▁▁█▁
Cold (Ready in log) 459ms 459ms ▁▁▂█▁
Cold (First Request) 861ms 866ms ▁▁▂█▁
Warm (Listen) 456ms 457ms ▁▁▁█▁
Warm (Ready in log) 458ms 458ms ▁▁▁█▁
Warm (First Request) 372ms 370ms ▁▁▂█▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ███▁█
Cold (Ready in log) 441ms 441ms ██▆▆▇
Cold (First Request) 1.833s 1.839s ▄▄▄▃▅
Warm (Listen) 456ms 456ms █▅▁▅▅
Warm (Ready in log) 440ms 440ms ▇▆▅▄▅
Warm (First Request) 1.855s 1.844s ▅▄▄▃▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.200s 4.311s ▁▁▃█▂
Cached Build 4.282s 4.287s ▁▁▃█▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.840s 13.864s ▁▁▂▁▄
Cached Build 13.920s 13.948s ▁▂▂▁▄
node_modules Size 464 MB 465 MB 🔴 +173 kB (+0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **434 kB** → **437 kB** ⚠️ +2.35 kB

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 764 B
Total 764 B 764 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 451 B
Total 451 B 451 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 254 B
main-HASH.js gzip 39 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.4 kB -
Total 228 kB 231 kB ⚠️ +2.99 kB
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.49 kB 2.49 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 248 kB 249 kB
Total 375 kB 375 kB ⚠️ +542 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 615 B 613 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 32.9 kB 33.2 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.5 kB 34.8 kB ⚠️ +254 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.79 MB 3.83 MB 🔴 +36.4 kB (+1%)
index.pack gzip 103 kB 103 kB
index.pack.old gzip 103 kB 102 kB 🟢 1.93 kB (-2%)
Total 4 MB 4.03 MB ⚠️ +33.8 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 312 kB
app-page-exp..prod.js gzip 166 kB 166 kB
app-page-tur...dev.js gzip 311 kB 311 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page-tur...dev.js gzip 308 kB 308 kB
app-page-tur..prod.js gzip 164 kB 164 kB
app-page.run...dev.js gzip 308 kB 308 kB
app-page.run..prod.js gzip 164 kB 164 kB
app-route-ex...dev.js gzip 70.4 kB 70.5 kB
app-route-ex..prod.js gzip 48.9 kB 49 kB
app-route-tu...dev.js gzip 70.4 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route-tu...dev.js gzip 70 kB 70.1 kB
app-route-tu..prod.js gzip 48.7 kB 48.8 kB
app-route.ru...dev.js gzip 70 kB 70.1 kB
app-route.ru..prod.js gzip 48.7 kB 48.7 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.1 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.1 kB 43.2 kB
pages-api.ru..prod.js gzip 32.8 kB 32.9 kB
pages-turbo....dev.js gzip 52.4 kB 52.5 kB
pages-turbo...prod.js gzip 39.4 kB 39.4 kB
pages.runtim...dev.js gzip 52.4 kB 52.5 kB
pages.runtim..prod.js gzip 39.3 kB 39.4 kB
server.runti..prod.js gzip 62.5 kB 62.6 kB
Total 2.77 MB 2.78 MB ⚠️ +2.24 kB
📝 Changed Files (25 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 5 more
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js
failed to diff
app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 6.17%

Comparing mischnic/remove-build-id (0063c95) with mischnic/flight-nav-requests-build-id (e0e23b6)

Summary

❌ 3 regressed benchmarks
✅ 14 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation packages-bundle.js[full] 999.1 ms 1,051.6 ms -4.99%
Simulation app-page-turbo.runtime.prod.js[full] 654.1 ms 697.1 ms -6.17%
Simulation app-page-turbo.runtime.prod.js[tracing] 571.2 ms 594.4 ms -3.9%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from 223f376 to 76b4cf6 Compare January 27, 2026 19:43
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 27682e6 to 18645bb Compare January 27, 2026 19:43
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from 76b4cf6 to ea8e86b Compare January 28, 2026 09:04
@mischnic mischnic force-pushed the mischnic/remove-build-id branch 2 times, most recently from 7bd2a14 to 99fecc0 Compare January 28, 2026 10:38
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from ea8e86b to cad2c36 Compare January 28, 2026 10:38
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 6621d9e to c3687a4 Compare January 28, 2026 16:24
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from cad2c36 to d5ca54e Compare January 29, 2026 08:55
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from c3687a4 to 4526717 Compare January 29, 2026 08:55
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from d5ca54e to 685d815 Compare January 29, 2026 10:52
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 4526717 to 27eb1b8 Compare January 29, 2026 10:52
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from 685d815 to e240cec Compare January 29, 2026 13:24
@mischnic mischnic force-pushed the mischnic/remove-build-id branch 2 times, most recently from c0e1fdb to 9f3a1e6 Compare January 29, 2026 13:35
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from e240cec to 4aa0a2d Compare January 29, 2026 13:35
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 9f3a1e6 to a6d330d Compare January 29, 2026 13:59
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from 4aa0a2d to df56610 Compare January 29, 2026 13:59
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from a6d330d to fc4a347 Compare January 29, 2026 14:03
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch from df56610 to 06dcfd5 Compare January 29, 2026 14:03
@mischnic mischnic force-pushed the mischnic/remove-build-id branch 2 times, most recently from 5b35cd8 to 8cefa74 Compare January 29, 2026 16:59
@mischnic mischnic marked this pull request as ready for review January 29, 2026 21:09
@mischnic mischnic requested a review from timneutkens January 29, 2026 21:10
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 8cefa74 to 81f7649 Compare January 30, 2026 11:40
@mischnic mischnic force-pushed the mischnic/flight-nav-requests-build-id branch 2 times, most recently from fed758a to a595e10 Compare January 30, 2026 17:26
@mischnic mischnic force-pushed the mischnic/remove-build-id branch from 81f7649 to 9a935fc Compare January 30, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next

3 participants