Skip to content

Replace build id in Pages data routes with deployment id, take 2 #89325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mischnic wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

Replace build id in Pages data routes with deployment id, take 2 #89325

mischnic wants to merge 1 commit into from
+514 −339

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 30, 2026 •
edited
Loading

Reapply #88959
Revert #89323

Closes PACK-6537

When a deployment id is available, don't put the data routes at _next/data/<BUILDID>/page.json, but at _next/data/page.json.
Deployment skew (forcing a MPA nav instead of a SPA nav if a deployment happened inbetween) is handled by comparing a header on the client side.

If you use output:export and set config.deploymentId (i.e. enable skew protection) you are still expected to set these headers.
This was referenced Jan 30, 2026
Open
Open
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 30, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.
@mischnic mischnic changed the title Reapply "Replace build id in Pages data routes with deployment id (#88959)" (#89323) Jan 30, 2026
vercel[bot]
vercel bot reviewed Jan 30, 2026
View reviewed changes
packages/next/src/server/normalizers/request/next-data.test.ts

it('should return true if it matches', () => {
const normalizer = new NextDataPathnameNormalizer('build-id')
const normalizer = new NextDataPathnameNormalizer(buildId, deploymentId)
Copy link
Contributor

@vercel vercel bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test "should return true if it matches" uses incorrect paths when deploymentId is set, not properly validating the normalizer's behavior for deployment-id scenario

Fix on Vercel
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 30, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 464 MB 464 MB 🔴 +97.1 kB (+0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 609ms 609ms ✓ ▁▁▁█▁
Cold (Ready in log) 570ms 567ms ✓ ▁▁▂█▁
Cold (First Request) 1.150s 1.146s ✓ ▁▁▂█▁
Warm (Listen) 609ms 608ms ✓ ▁▁▁█▁
Warm (Ready in log) 579ms 572ms ✓ ▁▁▁█▁
Warm (First Request) 449ms 439ms ✓ ▁▁▂█▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ███▁█
Cold (Ready in log) 442ms 443ms ✓ ██▆▆▇
Cold (First Request) 1.834s 1.844s ✓ ▄▄▄▃▅
Warm (Listen) 455ms 455ms ✓ █▅▁▅▅
Warm (Ready in log) 441ms 437ms ✓ ▇▆▅▄▅
Warm (First Request) 1.844s 1.837s ✓ ▅▄▄▃▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.586s 5.455s ✓ ▁▁▃█▂
Cached Build 5.428s 5.472s ✓ ▁▁▃█▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.730s 13.714s ✓ ▁▁▂▁▄
Cached Build 13.950s 13.914s ✓ ▁▂▂▁▄
node_modules Size 464 MB 464 MB 🔴 +97.1 kB (+0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **434 kB** → **435 kB** ⚠️ +144 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 761 B ✓
Total 764 B 761 B ✅ -3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 451 B ✓
Total 451 B 451 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 255 B ✓
main-HASH.js gzip 39 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 55.2 kB -
Total 228 kB 229 kB ⚠️ +796 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 248 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +457 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 616 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33.1 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +156 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.79 MB 3.81 MB 🔴 +16.5 kB (+0%)
index.pack gzip 102 kB 103 kB ✓
index.pack.old gzip 102 kB 102 kB ✓
Total 4 MB 4.02 MB ⚠️ +16.9 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 311 kB ✓
app-page-exp..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 311 kB 311 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 308 kB 308 kB ✓
app-page-tur..prod.js gzip 164 kB 164 kB ✓
app-page.run...dev.js gzip 308 kB 308 kB ✓
app-page.run..prod.js gzip 164 kB 164 kB ✓
app-route-ex...dev.js gzip 70.4 kB 70.5 kB ✓
app-route-ex..prod.js gzip 48.9 kB 49 kB ✓
app-route-tu...dev.js gzip 70.4 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.7 kB 48.8 kB ✓
app-route.ru...dev.js gzip 70 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.1 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.4 kB 52.5 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.4 kB 52.5 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.4 kB ✓
server.runti..prod.js gzip 62.5 kB 62.6 kB ✓
Total 2.77 MB 2.78 MB ⚠️ +1.19 kB
📝 Changed Files (25 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api-tu..ntime.dev.js
  • pages-api-tu..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • ... and 5 more
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api-tu..ntime.dev.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages-turbo...ntime.dev.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. tests type: next

3 participants

@mischnic @nextjs-bot