Fix extraction of font runs from text runs #40840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
cla-bot
bot
added
the
cla-signed
mikayla-maki
added a commit
that referenced
this pull request
Oct 22, 2025
Fixes a bug in #39928 The bug caused all completions to appear in bold-face Release Notes: - Fixed a bug where bold-face font was applied to the wrong characters in items in the autocomplete menu Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
cyndis
added a commit
to cyndis/zed
that referenced
this pull request
Nov 27, 2025
After zed-industries#39928, if a font's weight changes between text runs without other decoration changing, the earlier weight continues to be used for the subsequent run(s). PR zed-industries#40840 fixes this in shape_text, but similar code exists also in layout_text. The latter is used for text in the editor view itself, so the issue continues to appear when using a highlighting theme with varied font weights. Fix the issue by applying the same fix in layout_text.
Veykril
pushed a commit
that referenced
this pull request
Dec 1, 2025
After #39928, if a font's weight changes between text runs without other decoration changing, the earlier weight continues to be used for the subsequent run(s). PR #40840 fixes this in shape_text, but similar code exists also in layout_text. The latter is used for text in the editor view itself, so the issue continues to appear when using a highlighting theme with varied font weights. Fix the issue by applying the same fix in layout_text. Closes #42297 Release Notes: - Fixed incorrect font weights in editor view when using a highlighting theme with varying font weights
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
After #39928, if a font's weight changes between text runs without other decoration changing, the earlier weight continues to be used for the subsequent run(s). PR #40840 fixes this in shape_text, but similar code exists also in layout_text. The latter is used for text in the editor view itself, so the issue continues to appear when using a highlighting theme with varied font weights. Fix the issue by applying the same fix in layout_text. Closes #42297 Release Notes: - Fixed incorrect font weights in editor view when using a highlighting theme with varying font weights
zed-zippy bot
added a commit
that referenced
this pull request
Dec 5, 2025
…erry-pick to stable) (#44197) Cherry-pick of #43856 to stable ---- After #39928, if a font's weight changes between text runs without other decoration changing, the earlier weight continues to be used for the subsequent run(s). PR #40840 fixes this in shape_text, but similar code exists also in layout_text. The latter is used for text in the editor view itself, so the issue continues to appear when using a highlighting theme with varied font weights. Fix the issue by applying the same fix in layout_text. Closes #42297 Release Notes: - Fixed incorrect font weights in editor view when using a highlighting theme with varying font weights Co-authored-by: Mikko Perttunen <cyndis@kapsi.fi>
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…ies#43856) After zed-industries#39928, if a font's weight changes between text runs without other decoration changing, the earlier weight continues to be used for the subsequent run(s). PR zed-industries#40840 fixes this in shape_text, but similar code exists also in layout_text. The latter is used for text in the editor view itself, so the issue continues to appear when using a highlighting theme with varied font weights. Fix the issue by applying the same fix in layout_text. Closes zed-industries#42297 Release Notes: - Fixed incorrect font weights in editor view when using a highlighting theme with varying font weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #39928
The bug caused all completions to appear in bold-face
Release Notes: