vim: Move to opening html tag from / in closing tag #42513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Contributor
Author
|
This works, but not sure if this is the best way to handle it. I think the LSP returns the range for the opening and closing tags which includes both the |
Contributor
|
Sorry for the delay in reviewing. This change looks good, and I think it's fine to hack it in just for that case. Could you add a test or at least an extra test case to an existing one like this to verify that our behavior matches neovim's in this case? |
github-project-automation
bot
moved this to Community PRs
in Quality Week – December 2025
Pranav2612000
force-pushed
the
feat/vim-motion-move-to-opening-html-tag-from-slash
branch
from
93e465f to
f892375
Compare
Contributor
Author
|
@P1n3appl3 Thank you for the review. I've updated the commit to include a test now( added to the existing test case - thought that should be enough ). Can you please take another look whenever you have time? |
Pranav2612000
force-pushed
the
feat/vim-motion-move-to-opening-html-tag-from-slash
branch
from
f892375 to
32dca5f
Compare
Pranav2612000
force-pushed
the
feat/vim-motion-move-to-opening-html-tag-from-slash
branch
from
32dca5f to
f202ce4
Compare
|
Finally fixed! Thank you! |
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…2513) Closes zed-industries#41582 Release Notes: - Improves the '%' vim motion for html by moving the cursor to the opening tag when its positioned on the `/` ( slash ) of the closing tag
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…2513) Closes zed-industries#41582 Release Notes: - Improves the '%' vim motion for html by moving the cursor to the opening tag when its positioned on the `/` ( slash ) of the closing tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41582
Release Notes:
/( slash ) of the closing tag