direnv: Allow disabling env integration entirely #43764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Veykril
approved these changes
Dec 1, 2025
Member
Veykril
left a comment
Veykril
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, thanks!
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
Relates to zed-industries#35759, but maybe doesn't entirely fix it? I think it will improve the situation, at least. Also provides a workaround for the issue described in zed-industries#40094 (comment) for users of WSL + `nix-direnv`. Rationale: there are cases where automatic direnv integration is not always desirable, but Zed currently has no way of opting out of this integration besides `direnv revoke` (which is often not desirable). This PR provides such an opt-out for users who run into problems with the existing direnv integration methods. Some reasons why disabling might be useful: - Security concerns about auto-loading `.envrc` (arguably, `direnv revoke` should cover this most of the time) - As in zed-industries#35759, for users who use different shells/envs for interactive/non-interactive cases and want to manually control the environment Zed uses - As in zed-industries#40094, to workaround OS limits on environment variable / command-line parameter size Release Notes: - Added the ability to disable direnv integration entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #35759, but maybe doesn't entirely fix it? I think it will improve the situation, at least.
Also provides a workaround for the issue described in #40094 (comment) for users of WSL +
nix-direnv.Rationale: there are cases where automatic direnv integration is not always desirable, but Zed currently has no way of opting out of this integration besides
direnv revoke(which is often not desirable).This PR provides such an opt-out for users who run into problems with the existing direnv integration methods. Some reasons why disabling might be useful:
.envrc(arguably,direnv revokeshould cover this most of the time)Release Notes: