summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
raw | patch | inline | side by side (parent: 60ba3a5)
interface: never use SourceManager::createMainFileID()
authorSven Verdoolaege <sven.verdoolaege@gmail.com>
Sun, 19 Oct 2025 21:08:24 +0000 (19 23:08 +0200)
committerSven Verdoolaege <sven.verdoolaege@gmail.com>
Sat, 22 Nov 2025 14:26:18 +0000 (22 15:26 +0100)
Optionally not using SourceManager::createMainFileID() was introduced
in isl-0.13-114-g7cb5d879da (interface/extract_interface.cc: avoid
use of SourceManager::createMainFileID(), Sat Aug 30 20:10:30 2014 +0200),
but this method was removed before clang 3.5,
which is documented as the minimal supported version.

Signed-off-by: Sven Verdoolaege <sven.verdoolaege@gmail.com>
interface/extract_interface.cc patch | blob | blame | history
m4/ax_detect_clang.m4 patch | blob | blame | history

diff --git a/interface/extract_interface.cc b/interface/extract_interface.cc
index 4989bfb..0b86570 100644 (file)
--- a/interface/extract_interface.cc
+++ b/interface/extract_interface.cc
@@ -318,8 +318,6 @@ void add_path(HeaderSearchOptions &HSO, string Path)
        HSO.AddPath(Path, frontend::Angled, false, true);
 }
 
-#ifdef HAVE_SETMAINFILEID
-
 template <typename T>
 static void create_main_file_id(SourceManager &SM, const T &file)
 {
@@ -327,15 +325,6 @@ static void create_main_file_id(SourceManager &SM, const T &file)
                                        SrcMgr::C_User));
 }
 
-#else
-
-static void create_main_file_id(SourceManager &SM, const FileEntry *file)
-{
-       SM.createMainFileID(file);
-}
-
-#endif
-
 #ifdef SETLANGDEFAULTS_TAKES_5_ARGUMENTS
 
 #include "set_lang_defaults_arg4.h"
diff --git a/m4/ax_detect_clang.m4 b/m4/ax_detect_clang.m4
index 4ceeba4..ac5901f 100644 (file)
--- a/m4/ax_detect_clang.m4
+++ b/m4/ax_detect_clang.m4
@@ -130,9 +130,6 @@ AC_EGREP_HEADER([getReturnType],
        [clang/AST/CanonicalType.h], [],
        [AC_DEFINE([getReturnType], [getResultType],
            [Define to getResultType for older versions of clang])])
-AC_EGREP_HEADER([setMainFileID], [clang/Basic/SourceManager.h],
-       [AC_DEFINE([HAVE_SETMAINFILEID], [],
-       [Define if SourceManager has a setMainFileID method])])
 AC_CHECK_HEADER([llvm/ADT/OwningPtr.h],
        [AC_DEFINE([HAVE_ADT_OWNINGPTR_H], [],
                   [Define if llvm/ADT/OwningPtr.h exists])])
Integer set library