Return original URL param when it cannot be parsed

[epeicher]

Related issues

• Related STU-510
• Related Sync: Update notification to include Hostname #1412 (comment)

Proposed Changes

• Return the passed URL parameter when it cannot be parsed instead of an empty string

Testing Instructions

• Apply this branch and run npm start
• Go to the Sync tab and connect a site, or use one of your connected sites
• Run a Push or a Pull
• Check that the notification contains the hostname of the connected site

Additional testing

• You can force the URL to be invalid, for example applying this diff

diff --git i/src/hooks/sync-sites/use-sync-pull.ts w/src/hooks/sync-sites/use-sync-pull.ts
index ef0864e7..e4de1d71 100644
--- i/src/hooks/sync-sites/use-sync-pull.ts
+++ w/src/hooks/sync-sites/use-sync-pull.ts
@@ -226,7 +226,7 @@ export function useSyncPull( {
 					body: sprintf(
 						// translators: %s is the site url without the protocol.
 						__( 'Studio site has been updated from %s' ),
-						getHostnameFromUrl( remoteSiteUrl )
+						getHostnameFromUrl( remoteSiteUrl.replace( 'https://', '' ) )
 					),
 				} );

• And running a Pull and checking that you can still see the URL in the notification

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[katinthehatsite]

The changes look good to me, I tested both cases and did not spot any regressions. Nice work!

[ivan-ottinger]

Likewise! The change looks good and works as expected. 👌🏼 Example with pull when the parsing fails (having the suggested diff from the PR description applied):

[sejas]

Thank you for accepting the suggestion. I was worried that the text in the notifications might appear incoherent with a missing domain.

[sejas]

@ivan-ottinger, @epeicher, what do you think about merging this PR so it can be included in the 1.5.2 release?

[epeicher]

@ivan-ottinger, @epeicher, what do you think about merging this PR so it can be included in the 1.5.2 release?

This one is pretty safe to merge. I was waiting for the release to complete, but if @ivan-ottinger is OK with that, it can be included

[sejas]

Merging after getting approval from @ivan-ottinger : p1748005992305009/1747991964.446809-slack-C06DRMD6VPZ

[ivan-ottinger]

Merging after getting approval from @ivan-ottinger : p1748005992305009/1747991964.446809-slack-C06DRMD6VPZ

It took me some time to go through all the notifications. Thank you for the ping in Slack! Yes, all is looking good here. 🙂