Studio: Delete old proof-of-concept WP-CLI implementation

[katinthehatsite]

Related issues

Fixes STU-302

Proposed Changes

This PR removes the old implementation of the WP-CLI execution from the terminal (related PR) in favour of the studio CLI commands available right now.

Testing Instructions

Test Studio CLI to make sure everything works as expected:

I modified a couple of different things so let's test various aspects to make sure everything works as expected.

• Pull the changes from this branch
• Run npm install
• Run npm run cli:build
• Run node dist/cli/main.js preview list FOLDER where FOLDER is a path to a Studio site with preview sites (example: node dist/cli/main.js preview list --path="/Users/katerynakodonenko/Studio/my-bright-website")
• Ensure that the command either prints a table containing information about the preview sites or prints No snapshots found

Check opening different terminal apps

• Pull the changes from this branch
• Run npm install and npm start
• Once the app is started, navigate to the Overview tab
• Click on your preferred terminal app to open your site in that app
• Confirm that it open the site in a preferred terminal app
• Try out a couple of different terminal apps
• Confirm that it works correctly for different terminal apps

Check assistant code block running CLI inline

• Pull the changes from this branch
• Run npm install and npm start
• Once the app is started, navigate to the Assistant tab
• Ask Assistant for the CLI command for listing plugins on your site
• Run the command inline
• Confirm everything works:

TBD

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[katinthehatsite]

Not related to this PR but this code is not used so I removed it.

[fredrikekelund]

Thanks for tackling this! 👍 I haven't looked very closely, but wanted to leave an initial comment about the openTerminalAtPath function

[sejas]

Kat, this PR looks very promising. Great work.
The assistant is still working and I confirm the feature flag STUDIO_TERMINAL_WP_CLI has been removed.
For now I just added a small suggestion.

[nightnei]

Do you have this erorr on running Terminal or iTerm? I have it even in trunk, hm...

But everything else works well:

[katinthehatsite]

Do you have this erorr on running Terminal or iTerm? I have it even in trunk, hm...

I am not getting it on my end either or trunk on this PR? @sejas did this work for you when you were testing the PR?

@nightnei I am also going to explore this suggestion from Fredrik: #1426 (comment)
Perhaps you could retest once I make that change.

[katinthehatsite]

@nightnei I only looked briefly, but I am wondering if you have iTerm added in these settings:

[fredrikekelund]

	const preferredTerminal = await getUserTerminal();

	if ( platform === 'darwin' ) {
		const escapedPath = targetPath.replace( /"/g, '\\"' );
		const bundleIds = {
			warp: 'dev.warp.Warp-Stable',
			ghostty: 'com.mitchellh.ghostty',
			iterm: 'com.googlecode.iterm2',
			terminal: 'com.apple.Terminal',
		};
		return promiseExec( `open -b ${ bundleIds[ preferredTerminal ] } "${ escapedPath }"` );
	} else if ( platform === 'win32' ) {
		const defaultShell = process.env.ComSpec || 'cmd.exe';

A couple of comments:

• initScriptSteps can be removed completely. It's no longer used.
• Applications can be renamed by the user on macOS, so open -a is not a safe option. The bundle ID, however, cannot be changed, so it's better to use open -b for opening the application.
• We can use getUserTerminal to get the preferred terminal. I recommend removing the _event parameter from that function, as it's not used.
• terminalApps already map all SupportedTerminal keys to a value, so there's no need to have another fallback value.

[katinthehatsite]

Thanks for your suggestions, I made adjustments based on this. Feel free to give it another review 👍

[nightnei]

@katinthehatsite I don't have iTerm/Terminal there, but today I tested it again and I don't know what changed, but I don't see that error anymore:

[nightnei]

LGTM and works well - assistant, terminals, and CLI 👍

[fredrikekelund]

Thanks for making the additional changes, @katinthehatsite 👍 This looks good and works as expected (I've confirmed that all four terminal apps still open as expected on macOS)