Update Playground packages to 1.0.38 and remove the Symlink manager by bgrgicak · Pull Request #1425 · Automattic/studio

bgrgicak · 2025-05-22T06:20:12Z

Related issues

Related issues Studio app cannot activate WordPress plugins using Freemius if using MySQL database #854 Unable to resolve symlinked path in plugin on macOS #728 Enable symlinks on Windows #548
- STU-51
- STU-36
- STU-111
- STU-60
- STU-520

Proposed Changes

Update Playground packages to 1.0.38
Remove SymlinkManager
Activate Playground's followSymlinks feature
Remove @php-wasm/universal patch

Testing Instructions

Create a site in Studio
Symlink a plugin to the site's plugins folder
Confirm the plugin can be activated

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

TODO: update packages

bgrgicak · 2025-05-22T06:36:31Z

ERROR in ./node_modules/@php-wasm/web/shared/icudt74l.dat 1:0
Module parse failed: Unexpected character '�' (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)
 @ ./node_modules/@php-wasm/web/shared/icudt74l.js 1:0-42 2:0-24
 @ ./node_modules/@php-wasm/web/index.cjs 20:307-337
 @ ./node_modules/@wp-playground/blueprints/index.cjs 1:363-387
 @ ./vendor/wp-now/src/wp-now.ts 21:21-57
 @ ./vendor/wp-now/src/execute-wp-cli.ts 50:17-36
 @ ./src/lib/wp-cli-process-child.ts 13:25-68
webpack 5.94.0 compiled with 1 error and 3 warnings in 34340 ms
at cb (/opt/ci/builds/builder/automattic/studio/node_modules/@electron-forge/plugin-webpack/src/WebpackPlugin.ts:493:29)
    at finalCallback (/opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:498:32)
    at /opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:522:13
    at Hook.eval [as callAsync] (eval at create (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/Hook.js:18:14)
    at onCompiled (/opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:520:21)
    at /opt/ci/builds/builder/automattic/studio/node_modules/webpack/lib/Compiler.js:1348:17
    at eval (eval at create (/opt/ci/builds/builder/automattic/studio/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:14:1)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
🚨 Error: The command exited with status 1

bgrgicak · 2025-05-22T06:36:51Z

node_modules/@php-wasm/web/shared/icudt74l.dat the binary file is throwing a Module parse failed: Unexpected character '�' error.

epeicher

Thank you very much @bgrgicak for solving this! I have tested in Windows and Mac with absolute and relative symbolic links and they are all working as expected. LGTM!

Platform	Absolute	Relative with many levels
Windows
Mac

sejas · 2025-05-22T08:08:00Z

@@ -1,48 +0,0 @@
-diff --git a/node_modules/@php-wasm/universal/index.cjs b/node_modules/@php-wasm/universal/index.cjs


bgrgicak · 2025-05-22T08:57:02Z

I will wait with merging this PR until we release Studio 1.5.2 on Monday.

sejas

Yay! Thanks for upgrading the Playground dependencies and fixing the symlinks.
I confirm that both the relative and absolute symlinks are working correctly on Mac 🥳.

I tried creating these symlinks:

Relative: ln -s ../../../classic-editor classic-editor
Absolute: ln -s /Users/macbookpro/Studio/classic-editor classic-editor

ivan-ottinger · 2025-05-23T15:48:36Z

I will wait with merging this PR until we release Studio 1.5.2 on Monday.

Thank you, Bero!

sejas · 2025-05-26T17:21:02Z

I merged this PR since we already released 1.5.2 🥳

…1425) * Update Playground packages to 1.0.38 * Remove SymlinkManager * Activate Playground's followSymlinks feature * Remove @php-wasm/universal patch

commit d31733b Author: katinthehatsite <katerynakodonenko@gmail.com> Date: Tue May 27 09:12:55 2025 +0200 Studio: Delete old proof-of-concept WP-CLI implementation (#1426) * Remove old scripts * Remove old cli.ts * Cleanup tests * Clean up terminal opening and feature flag * Cleanup assistant code * Clean shortcuts code * Cleanup feature flags * Cleanup feature flags * Cleanup shortcuts sessions * Removed unused feature flag for assistant * Assistant code block test fix * Adjust preload * Cleanup index file and tests * Refactor terminal usage * Add back the lock * Remove unintended change * Remove unnecesary type for warp * Use bundled Ids * Cleanup event parameter --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> commit 4fac446 Author: Volodymyr Makukha <nei.css@gmail.com> Date: Mon May 26 20:19:35 2025 +0100 Update Ukrainian translations - May 26 (#1439) commit c7536ef Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Mon May 26 18:34:28 2025 +0100 Load LTR and RTL stylesheets conditionally (#1429) * Add a new component * Load @wordpress/components css conditionally based on RTL and LTR. * Load index.css a.k.a main_window.css after loading the WordPress stylesheet commit c80b70e Author: Bero <berislav.grgicak@gmail.com> Date: Mon May 26 19:20:42 2025 +0200 Update Playground packages to 1.0.38 and remove the Symlink manager (#1425) * Update Playground packages to 1.0.38 * Remove SymlinkManager * Activate Playground's followSymlinks feature * Remove @php-wasm/universal patch commit 5bfe676 Author: Wojtek Naruniec <wojtek.naruniec@automattic.com> Date: Mon May 26 15:40:18 2025 +0200 Sanitize regex in Win editor path (#1411) * Sanitize regex * Import only escapeRegExp function commit 2cd3e44 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Mon May 26 13:18:02 2025 +0200 Bump version from 1.5.2-beta4 to 1.5.2 (#1436) commit f16865e Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Mon May 26 12:38:24 2025 +0200 Add release notes for 1.5.2 (#1434) * Add release notes for 1.5.2 * Reorder release notes * Update release notes order and formatting * Added latest UI fix to the release notes * Consolidate Studio CLI fixes into a single bullet point commit f6e48d5 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Mon May 26 12:21:30 2025 +0200 Add translations for 1.5.2 (#1433) * Add translations for 1.5.2 * Add latest Polish and Spanish translations * Update spanish translations --------- Co-authored-by: Antonio Sejas <antonio@sejas.es> commit ae1d163 Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Mon May 26 10:58:22 2025 +0100 Share same styles between preview and sync tabs (#1435) commit d6a7905 Author: Roberto Aranda <roberto.aranda@automattic.com> Date: Fri May 23 15:23:14 2025 +0200 Return original URL param when it cannot be parsed (#1420) * Return the passed URL parameter when it cannot be parsed instead of an empty string commit 91d04be Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Fri May 23 14:22:34 2025 +0100 Update localized docs links for Studio Sync and Studio CLI (#1431) * Add translation link to new Spanish studio docs CLI * Add hash to Studio sync supported sites commit 6213094 Author: katinthehatsite <katerynakodonenko@gmail.com> Date: Fri May 23 14:27:53 2025 +0200 Add patch to fix the accessibility with modals (#1423) Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> commit b2724c0 Author: Rahul Gavande <rahul.gavande@automattic.com> Date: Fri May 23 14:45:11 2025 +0530 Use uri scheme to open Warp terminal app (#1428) commit 43c831b Author: Fredrik Rombach Ekelund <fredrik@f26d.dev> Date: Wed May 21 16:10:40 2025 +0200 CLI: Set UTF8 encoding for output on Windows (#1424) commit b1c0eeb Author: Volodymyr Makukha <nei.css@gmail.com> Date: Wed May 21 10:34:47 2025 +0100 Fix hiding plugins spinner (#1419) commit 48988ed Author: Fredrik Rombach Ekelund <fredrik@f26d.dev> Date: Wed May 21 10:31:33 2025 +0200 Add migration to rename launch uniques stat (#1415) * Add migration to rename launch uniques stat * Fix CLI zod schema commit f363144 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Tue May 20 18:24:00 2025 +0200 Bump version to 1.5.2-beta4 (#1421) commit 9768e67 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Tue May 20 15:29:33 2025 +0200 Pressable Sync: Fix remaining Sync modal issues (#1416) * Use absolute path for `WordPressLogoCircle` import * Use separate `isDisabled` to makde WP logo gray * Remove trailing space in site selector helper text * Decrease font size of sync sites modal learn more link commit 9fab398 Author: Ian G. Maia <iangmaia@users.noreply.github.com> Date: Tue May 20 13:15:23 2025 +0200 [Tooling] Update code to DRY the Windows build PS1 (#1408) * Update code to DRY the Windows build PS1 * Update case of `Exit` command * Use `windows` instead of just `win` to prefix windows-related scripts * Add $LastExitCode check after `npm run make` commit e5d4006 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Tue May 20 12:01:21 2025 +0200 Improve version comparison logic to handle prerelease transitions correctly (#1403) commit f0a282b Author: Rahul Gavande <rahul.gavande@automattic.com> Date: Tue May 20 15:15:25 2025 +0530 HTTPS: Convert domain name Unicode characters to ASCII characters (#1400) * Convert domain name unicode chars to ASCII * Do not use punnycode domain name for paths * Remove unncessary punnycode domain name commit 6cdc351 Author: Roberto Aranda <roberto.aranda@automattic.com> Date: Tue May 20 11:35:52 2025 +0200 Sync: Update notification to include Hostname (#1412) * Push: Update notification to include Hostname * Pull: Update notification to include hostname * Add hints for translators commit 69419a6 Author: Gergely Csécsey <gergely.csecsey@automattic.com> Date: Tue May 20 10:30:57 2025 +0100 Increase HTTP request timeout to 60 seconds (#1407) * Increase HTTP request timeout to 60 seconds * Increase curl timeout to 60 seconds * update comments commit 6bcbbff Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Tue May 20 09:36:18 2025 +0100 Update connect site text button when connecting another site (#1413) * Adapt the "Connect Site" button when connecting multiple sites on Sync. commit 60a9cab Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Tue May 20 09:10:37 2025 +0100 Avoid orphan in sync title (#1414) commit 3b103cc Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Mon May 19 10:39:12 2025 +0100 Release 1.5.2-beta3 (#1410) commit a109671 Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Mon May 19 09:45:17 2025 +0200 Sync: Update sync tab text and remove WordPress logo from title (#1405) * Update sync tab text and remove WordPress logo from title * Fix related test * Use comma * Update copy of the bullet points * Replace `WP.com` with `WordPress.com`. Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com> * Replace WP.com with WordPress.com Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com> * Delete unused WordPress short logo component --------- Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com> commit 716bc7a Author: Ivan Ottinger <ivan.ottinger@automattic.com> Date: Fri May 16 16:15:16 2025 +0200 Sync: Update Sync modal content (#1406) * Update WordPress logo component `viewBox` * Update Sync modal heading * Update text below Sync search field * Update Sync modal site logos * Replace hardcoded arrows with `ArrowIcon` component in sync sites modal links * Localize sync modal Read more link using `getLocalizedLink` utility commit 11b4302 Author: Roberto Aranda <roberto.aranda@automattic.com> Date: Fri May 16 15:14:40 2025 +0200 Push: Read and update the progress from the sync endpoint (#1389) * Calls the GET /sync/import using the importId to obtain the progress * Use the progress from the /sync/import endpoint to update the progress in the importing state * Splits the progress of the importing state between backup and import commit 7423bdf Author: katinthehatsite <katerynakodonenko@gmail.com> Date: Fri May 16 11:40:18 2025 +0200 Studio: Fix no directory or file error on Windows (#1391) * Fix no directory or file error on Windows * Cleanup directories --------- Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com> commit 1661ac4 Author: Antonio Sejas <antonio.sejas@automattic.com> Date: Fri May 16 10:04:32 2025 +0100 Force display of what's new for minor version (#1404) * Force what's new display for minor version * Skip test that compares the patch version

bgrgicak added 3 commits May 6, 2025 15:09

Change version

3364c56

TODO: update packages

Replace symlink manager with followSymlinks from Playground

9654f99

Update Playground packages to 1.0.38

fc47d62

bgrgicak self-assigned this May 22, 2025

bgrgicak added the Enhancement label May 22, 2025

bgrgicak requested review from sejas and wojtekn May 22, 2025 06:20

bgrgicak added 2 commits May 22, 2025 08:27

Merge branch 'trunk' into update/playground-to-1.0.32

a091dad

Remove PHP-wasm universal patch

38e8b13

bgrgicak marked this pull request as draft May 22, 2025 06:43

bgrgicak added 2 commits May 22, 2025 08:45

Webpack ignore .dat files

58663cc

Ignore only node_modules/@php-wasm/web/shared/ dat files

764ae00

bgrgicak marked this pull request as ready for review May 22, 2025 06:59

bgrgicak requested a review from a team May 22, 2025 06:59

wojtekn mentioned this pull request May 22, 2025

Update Playground dependencies to 1.0.36 #1355

Closed

1 task

sejas added the DO NOT MERGE label May 22, 2025

epeicher approved these changes May 22, 2025

View reviewed changes

sejas reviewed May 22, 2025

View reviewed changes

bgrgicak added 2 commits May 22, 2025 10:43

Use ignore-loader on all .dat files

2e15e28

Change assert from use to type

e84966f

sejas approved these changes May 22, 2025

View reviewed changes

sejas removed the DO NOT MERGE label May 26, 2025

sejas merged commit c80b70e into trunk May 26, 2025

sejas deleted the update/playground-to-1.0.32 branch May 26, 2025 17:20

This was referenced May 27, 2025

Studio app cannot activate WordPress plugins using Freemius if using MySQL database #854

Closed

Unable to resolve symlinked path in plugin on macOS #728

Closed

Enable symlinks on Windows #548

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Playground packages to 1.0.38 and remove the Symlink manager - #1425

Update Playground packages to 1.0.38 and remove the Symlink manager#1425
sejas merged 9 commits into
trunkfrom
update/playground-to-1.0.32

bgrgicak commented May 22, 2025 •

edited by wojtekn

Loading

bgrgicak commented May 22, 2025

bgrgicak commented May 22, 2025 •

edited

Loading

epeicher left a comment

sejas May 22, 2025

Uh oh!

bgrgicak commented May 22, 2025

sejas left a comment

ivan-ottinger commented May 23, 2025

sejas commented May 26, 2025

Labels

4 participants

		@@ -1,48 +0,0 @@
		diff --git a/node_modules/@php-wasm/universal/index.cjs b/node_modules/@php-wasm/universal/index.cjs

Uh oh!

Conversation

bgrgicak commented May 22, 2025 • edited by wojtekn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Proposed Changes

Testing Instructions

Pre-merge Checklist

bgrgicak commented May 22, 2025

bgrgicak commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

epeicher left a comment

Choose a reason for hiding this comment

sejas May 22, 2025

Choose a reason for hiding this comment

Uh oh!

bgrgicak commented May 22, 2025

sejas left a comment

Choose a reason for hiding this comment

ivan-ottinger commented May 23, 2025

sejas commented May 26, 2025

Labels

4 participants

bgrgicak commented May 22, 2025 •

edited by wojtekn

Loading

bgrgicak commented May 22, 2025 •

edited

Loading