Skip to content

drivers: sdhc: litex: add support for litesdcard#93816

Open
maass-hamburg wants to merge 2 commits intozephyrproject-rtos:mainfrom
maass-hamburg:litex_litesdcard
Open

drivers: sdhc: litex: add support for litesdcard#93816
maass-hamburg wants to merge 2 commits intozephyrproject-rtos:mainfrom
maass-hamburg:litex_litesdcard

Conversation

@maass-hamburg
Copy link
Member

@maass-hamburg maass-hamburg commented Jul 29, 2025 •
edited
Loading

add support for litesdcard
@maass-hamburg maass-hamburg mentioned this pull request Jul 29, 2025
Draft
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@maass-hamburg maass-hamburg force-pushed the litex_litesdcard branch 2 times, most recently from 7e45bc7 to 66018ac Compare September 16, 2025 14:25
@maass-hamburg maass-hamburg force-pushed the litex_litesdcard branch 5 times, most recently from 64cab63 to 0f7b26b Compare October 17, 2025 10:25
@maass-hamburg maass-hamburg mentioned this pull request Oct 17, 2025
Open
3 tasks
@maass-hamburg maass-hamburg marked this pull request as ready for review October 17, 2025 11:11
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Oct 21, 2025

rebased because #97444 got merged, now between the other peripherals
@maass-hamburg maass-hamburg mentioned this pull request Nov 4, 2025
Merged
@jhedberg jhedberg modified the milestones: v4.3.0, v4.4.0 Nov 11, 2025
danieldegrasse
danieldegrasse reviewed Nov 14, 2025
View reviewed changes
drivers/sdhc/sdhc_litex_litesdcard.c
if (ret == 0) {
if ((cmd->opcode == SD_APP_SEND_SCR) &&
(cmd->response[0] & SD_R1_APP_CMD)) {
sdhc_litex_check_cmd23_support(dev, data);
Copy link
Contributor

@danieldegrasse danieldegrasse Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also be able to determine CMD23 support by looking at the timing the host selects, if UHS timing is used you can assume CMD23 is possible.
Copy link
Member Author

@maass-hamburg maass-hamburg Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litesdcard doesn't supports uhs (it doesn't support voltage switching), therefore this is the best way for now. Supoort for adding externel level translators (like https://www.ti.com/product/de-de/LSF0108/part-details/LSF0108PWR) might be added later.
drivers/sdhc/sdhc_litex_litesdcard.c
static const struct sdhc_litex_config sdhc_litex_config_##n = { \
.irq_config_func = sdhc_litex_irq_config##n, \
.bus_width = (enum sdhc_bus_width)DT_INST_PROP(n, bus_width), \
.phy_card_detect_addr = DT_INST_REG_ADDR_BY_NAME(n, phy_card_detect), \
Copy link
Contributor

@danieldegrasse danieldegrasse Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all these register offsets differ between each version of the IP? Or could we encode one base address?
Copy link
Member Author

@maass-hamburg maass-hamburg Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how we do it with all litex peripherals. The order and the position of the registers is not fixed and not considered stable. It can always change. Btw it is open source https://github.com/enjoy-digital/litesdcard and changes can happen anytime. F.e. when a new register is added, the addresses of the other registers can change. We don't want to have to change the driver for that and handle versions for that. Instead the user just has to update the entries in their dts accordingly.
boards/enjoydigital/litex_vexriscv/litex_vexriscv.dts
sdhc0: sdhc@e000e800 {
compatible = "litex,litesdcard-sdhc";
interrupt-parent = <&intc0>;
reg = <0xe000e800 0x4>,
Copy link
Contributor

@danieldegrasse danieldegrasse Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we can use one base address here. Or are all these register offsets configurable in the RTL?
Copy link
Member Author

@maass-hamburg maass-hamburg Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no see other answer
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Nov 18, 2025

rebased due to merge conflicts
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Dec 2, 2025

@danieldegrasse PTAL
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Dec 8, 2025

rebased due to a conflict
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Jan 13, 2026
@maass-hamburg maass-hamburg mentioned this pull request Jan 15, 2026
Open
@maass-hamburg maass-hamburg force-pushed the litex_litesdcard branch 2 times, most recently from ed8b625 to 0a9bc5e Compare January 27, 2026 09:15
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Jan 27, 2026

rebased due to sdhc api changes, also cleaned up sdhc_litex_get_host_props
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Jan 27, 2026

@danieldegrasse please re-review
@maass-hamburg
drivers: sdhc: litex: add litesdcard driver
85dd476 
add litex litesdcard driver.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@maass-hamburg
boards: litex: litex_vexriscv: add litesdcard
0d8b8ae 
add litesdcard host controller.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Feb 10, 2026

Changed compatible to match the one in Linux, which is litex,mmc https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/mmc/litex%2Cmmc.yaml

Also now uses events for interrupts
@maass-hamburg
Copy link
Member Author

maass-hamburg commented Feb 19, 2026

@tgorochowik @kgugala please take a look too, needs the second approve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment